mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jason Wang <jasowang@redhat.com>
Cc: rusty@rustcorp.com.au, mst@redhat.com,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Dalton <mwdalton@google.com>,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net] virtio-net: fix page refcnt leaking when fail to allocate frag skb
Date: Tue, 19 Nov 2013 06:03:48 -0800	[thread overview]
Message-ID: <1384869828.8604.97.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1384848307-7217-1-git-send-email-jasowang@redhat.com>

On Tue, 2013-11-19 at 16:05 +0800, Jason Wang wrote:
> We need to drop the refcnt of page when we fail to allocate an skb for frag
> list, otherwise it will be leaked. The bug was introduced by commit
> 2613af0ed18a11d5c566a81f9a6510b73180660a ("virtio_net: migrate mergeable rx
> buffers to page frag allocators").
> 
> Cc: Michael Dalton <mwdalton@google.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> The patch was needed for 3.12 stable.

Good catch, but if we return from receive_mergeable() in the 'middle'
of the frags we would need for the current skb, who will
call the virtqueue_get_buf() to flush the remaining frags ?

Don't we also need to call virtqueue_get_buf() like 

while (--num_buf) {
    buf = virtqueue_get_buf(rq->vq, &len);
    if (!buf)
        break;
    put_page(virt_to_head_page(buf));
}

?





  reply	other threads:[~2013-11-19 14:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19  8:05 Jason Wang
2013-11-19 14:03 ` Eric Dumazet [this message]
2013-11-19 18:44   ` Michael S. Tsirkin
2013-11-19 20:49   ` Michael S. Tsirkin
2013-11-19 21:36     ` Eric Dumazet
2013-11-19 21:53       ` Michael S. Tsirkin
2013-11-19 22:00         ` Eric Dumazet
2013-11-20  1:34           ` Michael Dalton
2013-11-20  3:17             ` Jason Wang
2013-11-20  9:00             ` Michael S. Tsirkin
2013-11-20  8:58           ` Michael S. Tsirkin
2013-11-20 15:16             ` Eric Dumazet
2013-11-20 16:06               ` Michael S. Tsirkin
2013-11-20 16:14                 ` Eric Dumazet
2013-11-20 17:03                   ` Michael S. Tsirkin
2013-11-19 21:38     ` Michael Dalton
2013-11-20  9:06       ` Michael S. Tsirkin
2013-11-20  3:05     ` Jason Wang
2013-11-20  3:00   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384869828.8604.97.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mwdalton@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®