From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752886Ab3KUGOc (ORCPT ); Thu, 21 Nov 2013 01:14:32 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:40050 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054Ab3KUGO3 (ORCPT ); Thu, 21 Nov 2013 01:14:29 -0500 From: Milo Kim To: Bryan Wu CC: , , Milo Kim , =?UTF-8?q?Pali=20Roh=C3=A1r?= Subject: [PATCH 2/3] leds: lp5521/5523: Remove duplicate mutex Date: Thu, 21 Nov 2013 15:14:20 +0900 Message-ID: <1385014460-6443-1-git-send-email-milo.kim@ti.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It can be a problem when a pattern is loaded via the firmware interface. LP55xx common driver has already locked the mutex in 'lp55xx_firmware_loaded()'. So it should be deleted. Cc: Pali Rohár Signed-off-by: Milo Kim --- drivers/leds/leds-lp5521.c | 4 ---- drivers/leds/leds-lp5523.c | 4 ---- 2 files changed, 8 deletions(-) diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c index 26f89ac..4c45ed9 100644 --- a/drivers/leds/leds-lp5521.c +++ b/drivers/leds/leds-lp5521.c @@ -258,8 +258,6 @@ static int lp5521_update_program_memory(struct lp55xx_chip *chip, if (i % 2) goto err; - mutex_lock(&chip->lock); - for (i = 0; i < LP5521_PROGRAM_LENGTH; i++) { ret = lp55xx_write(chip, addr[idx] + i, pattern[i]); if (ret) { @@ -268,8 +266,6 @@ static int lp5521_update_program_memory(struct lp55xx_chip *chip, } } - mutex_unlock(&chip->lock); - return size; err: diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 2ce1723..7a3b369 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -351,8 +351,6 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip, if (i % 2) goto err; - mutex_lock(&chip->lock); - for (i = 0; i < LP5523_PROGRAM_LENGTH; i++) { ret = lp55xx_write(chip, LP5523_REG_PROG_MEM + i, pattern[i]); if (ret) { @@ -361,8 +359,6 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip, } } - mutex_unlock(&chip->lock); - return size; err: -- 1.7.9.5