From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413Ab3KUIe0 (ORCPT ); Thu, 21 Nov 2013 03:34:26 -0500 Received: from cpsmtpb-ews04.kpnxchange.com ([213.75.39.7]:55187 "EHLO cpsmtpb-ews04.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805Ab3KUIeZ (ORCPT ); Thu, 21 Nov 2013 03:34:25 -0500 Message-ID: <1385022862.11741.9.camel@x220.thuisdomein> Subject: Re: [PATCH] [SCSI] bnx2i: add a prefix to a printk From: Paul Bolle To: Eddie Wai , "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Joe Perches Date: Thu, 21 Nov 2013 09:34:22 +0100 In-Reply-To: <1340825211.1911.42.camel@x61.thuisdomein> References: <1340825211.1911.42.camel@x61.thuisdomein> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 21 Nov 2013 08:34:22.0347 (UTC) FILETIME=[7A676DB0:01CEE694] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (Eddie was added as maintainer a few months ago, so Eddie receives this message too.) On Wed, 2012-06-27 at 21:26 +0200, Paul Bolle wrote: > During each suspend and resume cycle a mysterious message is added to > the logs: > CPU 1 offline: Remove Rx thread > > Some grepping of the tree revealed this message is printed by bnx2i. > Add a prefix to this message to make it clear that it is printed by > bnx2i. That should also make it obvious it is the mirror of the > bnx2i: CPU 1 online: Create Rx thread > > message. > > Signed-off-by: Paul Bolle This issue is still present. Could someone please have a look at this patch? > 0) Untested! It's tested now (on top of v3.12.1). > 1) I only noticed this because I've been looking at the log messages > generated by suspend and resume (for some iwlegacy and i915 issues) and > because Fedora 16 enables bnx2i by default. Fedora 18 still enables bnx2i by default. > 2) This triggers a checkpatch warning: > WARNING: Prefer pr_info(... to printk(KERN_INFO, ... > > So I added Joe to the Cc's to suggest a way to make all printks in this > file end up with a "bnx2i:" prefix (or whatever prefix is preferred). > > drivers/scsi/bnx2i/bnx2i_init.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c > index 8b68167..b75864b 100644 > --- a/drivers/scsi/bnx2i/bnx2i_init.c > +++ b/drivers/scsi/bnx2i/bnx2i_init.c > @@ -456,7 +456,8 @@ static int bnx2i_cpu_callback(struct notifier_block *nfb, > break; > case CPU_DEAD: > case CPU_DEAD_FROZEN: > - printk(KERN_INFO "CPU %x offline: Remove Rx thread\n", cpu); > + printk(KERN_INFO "bnx2i: CPU %x offline: Remove Rx thread\n", > + cpu); > bnx2i_percpu_thread_destroy(cpu); > break; > default: Paul Bolle