From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715Ab3KUOny (ORCPT ); Thu, 21 Nov 2013 09:43:54 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:51874 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754495Ab3KUOnG (ORCPT ); Thu, 21 Nov 2013 09:43:06 -0500 From: Ramkumar Ramachandra To: LKML Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim Subject: [PATCH 2/4] perf diff: give Delta column an appropriate color Date: Thu, 21 Nov 2013 20:03:45 +0530 Message-Id: <1385044427-13995-3-git-send-email-artagnon@gmail.com> X-Mailer: git-send-email 1.8.5.rc0.5.g70ebc73.dirty In-Reply-To: <1385044427-13995-1-git-send-email-artagnon@gmail.com> References: <1385044427-13995-1-git-send-email-artagnon@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colorize the numbers in the Delta column either green or red depending on whether the it is positive or negative. Cc: Jiri Olsa Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-diff.c | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index 79e0448..692c155 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -769,6 +769,33 @@ static int hpp__entry_baseline(struct hist_entry *he, char *buf, size_t size) return ret; } +static int hpp__color_delta(struct perf_hpp_fmt *fmt, + struct perf_hpp *hpp, struct hist_entry *he) +{ + struct diff_hpp_fmt *dfmt = + container_of(fmt, struct diff_hpp_fmt, fmt); + struct hist_entry *pair = get_pair_fmt(he, dfmt); + double percent; + char pfmt[20] = " "; + + if (!pair) + goto dummy_print; + if (pair->diff.computed) + percent = pair->diff.period_ratio_delta; + else + percent = compute_delta(he, pair); + + if (!he->dummy) { + scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1); + return color_snprintf(hpp->buf, hpp->size, + percent > 0 ? PERF_COLOR_GREEN : PERF_COLOR_RED, + pfmt, percent); + } else +dummy_print: + return scnprintf(hpp->buf, hpp->size, "%*s", + dfmt->header_width, pfmt); +} + static void hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size) { @@ -943,8 +970,16 @@ static void data__hpp_register(struct data__file *d, int idx) fmt->entry = hpp__entry_global; /* TODO more colors */ - if (idx == PERF_HPP_DIFF__BASELINE) + switch (idx) { + case PERF_HPP_DIFF__BASELINE: fmt->color = hpp__color_baseline; + break; + case PERF_HPP_DIFF__DELTA: + fmt->color = hpp__color_delta; + break; + default: + break; + } init_header(d, dfmt); perf_hpp__column_register(fmt); -- 1.8.5.rc0.5.g70ebc73.dirty