From: Conrad Gomes <conrad.s.j.gomes@gmail.com>
To: abbotti@mev.co.uk, hsweeten@visionengravers.com,
gregkh@linuxfoundation.org, joe@perches.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Conrad Gomes <conrad.s.j.gomes@gmail.com>
Subject: [PATCH V2 4/7] Staging: comedi: change pr_err to dev_err in __unioxx5_analog_read
Date: Fri, 22 Nov 2013 01:27:55 +0530 [thread overview]
Message-ID: <1385063878-10267-5-git-send-email-conrad.s.j.gomes@gmail.com> (raw)
In-Reply-To: <1385063878-10267-1-git-send-email-conrad.s.j.gomes@gmail.com>
This is a patch which subsitutes pr_err with dev_err in
__unioxx5_analog_read as it is the preferred way to log in device
drivers
Signed-off-by: Conrad Gomes <conrad.s.j.gomes@gmail.com>
---
drivers/staging/comedi/drivers/unioxx5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/unioxx5.c b/drivers/staging/comedi/drivers/unioxx5.c
index 31736ed..7edbd5e 100644
--- a/drivers/staging/comedi/drivers/unioxx5.c
+++ b/drivers/staging/comedi/drivers/unioxx5.c
@@ -175,7 +175,7 @@ static int __unioxx5_analog_read(struct comedi_subdevice *s,
/* defining if given module can work on input */
if (usp->usp_module_type[module_no] & MODULE_OUTPUT_MASK) {
- pr_err("comedi%d: module in position %d with id 0x%02x is for output only",
+ dev_err(csdev, "comedi%d: module in position %d with id 0x%02x is for output only",
minor, module_no, usp->usp_module_type[module_no]);
return 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2013-11-21 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 19:57 [PATCH V2 0/7] Staging: comedi: fix coding style issues in unioxx5.c Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 1/7] Staging: comedi: fix line over 80 character warning " Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 2/7] " Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 3/7] Staging: comedi: change printk to dev_err/dev_dbg " Conrad Gomes
2013-11-21 19:57 ` Conrad Gomes [this message]
2013-11-21 19:57 ` [PATCH V2 5/7] Staging: comedi: change pr_err to dev_err in __unioxx5_digital_write Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 6/7] Staging: comedi: change pr_err to dev_err in __unioxx5_analog_write Conrad Gomes
2013-11-21 19:57 ` [PATCH V2 7/7] Staging: comedi: remove MACRO pr_fmt in unioxx5.c Conrad Gomes
2013-11-25 10:13 ` [PATCH V2 0/7] Staging: comedi: fix coding style issues " Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385063878-10267-5-git-send-email-conrad.s.j.gomes@gmail.com \
--to=conrad.s.j.gomes@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®