From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755330Ab3KVHuT (ORCPT ); Fri, 22 Nov 2013 02:50:19 -0500 Received: from mail-lb0-f173.google.com ([209.85.217.173]:42722 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789Ab3KVHuB (ORCPT ); Fri, 22 Nov 2013 02:50:01 -0500 From: Chang Xiangzhong To: vyasevich@gmail.com, nhorman@tuxdriver.com, davem@davemloft.net Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chang Xiangzhong Subject: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle Date: Fri, 22 Nov 2013 08:49:49 +0100 Message-Id: <1385106589-402-1-git-send-email-changxiangzhong@gmail.com> X-Mailer: git-send-email 1.8.4.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tsn_gap_acked is an important state flag in chunk, which indicates if the chunk has been acked in gap reports before. SFR-CACC algorithm depends on this variable. So set this at the end of each iteration, otherwise the SFR-CACC algorithm would never be toggled. Signed-off-by: Chang Xiangzhong --- net/sctp/outqueue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c index 1b494fa..bff828c 100644 --- a/net/sctp/outqueue.c +++ b/net/sctp/outqueue.c @@ -1396,7 +1396,6 @@ static void sctp_check_transmitted(struct sctp_outq *q, * while DATA was outstanding). */ if (!tchunk->tsn_gap_acked) { - tchunk->tsn_gap_acked = 1; if (TSN_lt(*highest_new_tsn_in_sack, tsn)) *highest_new_tsn_in_sack = tsn; bytes_acked += sctp_data_size(tchunk); @@ -1460,6 +1459,8 @@ static void sctp_check_transmitted(struct sctp_outq *q, */ list_add_tail(lchunk, &tlist); } + + tchunk->tsn_gap_acked = 1; } else { if (tchunk->tsn_gap_acked) { pr_debug("%s: receiver reneged on data TSN:0x%x\n", -- 1.8.4.3