mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH v2 5/5] perf diff: color the Weighted Diff column
Date: Sun, 24 Nov 2013 11:50:25 +0530	[thread overview]
Message-ID: <1385274025-30282-6-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1385274025-30282-1-git-send-email-artagnon@gmail.com>

In

  $ perf diff -c wdiff:M,N

color the numbers in the Weighted Diff column either green or red,
depending on whether the number is positive or negative.

Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 tools/perf/builtin-diff.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index be2550c..f3f5d8e 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -777,6 +777,7 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
 		container_of(fmt, struct diff_hpp_fmt, fmt);
 	struct hist_entry *pair = get_pair_fmt(he, dfmt);
 	double delta;
+	s64 wdiff;
 	char pfmt[20] = " ";
 
 	if (!pair)
@@ -789,6 +790,9 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
 		case COMPUTE_RATIO:
 			delta = pair->diff.period_ratio;
 			break;
+		case COMPUTE_WEIGHTED_DIFF:
+			wdiff = pair->diff.wdiff;
+			break;
 		default:
 			BUG_ON(1);
 		}
@@ -800,6 +804,9 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
 		case COMPUTE_RATIO:
 			delta = compute_ratio(he, pair);
 			break;
+		case COMPUTE_WEIGHTED_DIFF:
+			wdiff = compute_wdiff(he, pair);
+			break;
 		default:
 			BUG_ON(1);
 		}
@@ -819,6 +826,12 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
 			return percent_color_snprintf(hpp->buf, hpp->size,
 						pfmt, delta);
 			break;
+		case COMPUTE_WEIGHTED_DIFF:
+			scnprintf(pfmt, 20, "%%14ld", dfmt->header_width);
+			return color_snprintf(hpp->buf, hpp->size,
+					wdiff > 0 ? PERF_COLOR_GREEN : PERF_COLOR_RED,
+					pfmt, wdiff);
+			break;
 		default:
 			BUG_ON(1);
 		}
@@ -840,6 +853,12 @@ static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
 	return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
 }
 
+static int hpp__color_wdiff(struct perf_hpp_fmt *fmt,
+			struct perf_hpp *hpp, struct hist_entry *he)
+{
+	return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF);
+}
+
 static void
 hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
 {
@@ -1024,6 +1043,9 @@ static void data__hpp_register(struct data__file *d, int idx)
 	case PERF_HPP_DIFF__RATIO:
 		fmt->color = hpp__color_ratio;
 		break;
+	case PERF_HPP_DIFF__WEIGHTED_DIFF:
+		fmt->color = hpp__color_wdiff;
+		break;
 	default:
 		break;
 	}
-- 
1.8.5.rc0.5.g70ebc73.dirty


      parent reply	other threads:[~2013-11-24  6:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-24  6:20 [PATCH v2 0/5] More color in 'perf diff' Ramkumar Ramachandra
2013-11-24  6:20 ` [PATCH v2 1/5] perf diff: don't compute Delta if he->dummy Ramkumar Ramachandra
2013-11-26 11:32   ` Jiri Olsa
2013-11-27  9:53     ` Ramkumar Ramachandra
2013-11-24  6:20 ` [PATCH v2 2/5] perf diff: color the Delta column Ramkumar Ramachandra
2013-11-26 11:42   ` Jiri Olsa
2013-11-27  9:32     ` Ramkumar Ramachandra
2013-11-24  6:20 ` [PATCH v2 3/5] perf diff: generalize hpp__color_delta for -c Ramkumar Ramachandra
2013-11-26 12:01   ` Jiri Olsa
2013-11-27  9:20     ` Ramkumar Ramachandra
2013-11-27 11:02       ` Ramkumar Ramachandra
2013-11-26 12:02   ` Jiri Olsa
2013-11-27  9:20     ` Ramkumar Ramachandra
2013-11-24  6:20 ` [PATCH v2 4/5] perf diff: color the Ratio column Ramkumar Ramachandra
2013-11-24  6:20 ` Ramkumar Ramachandra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385274025-30282-6-git-send-email-artagnon@gmail.com \
    --to=artagnon@gmail.com \
    --cc=acme@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®