From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756644Ab3KXKdx (ORCPT ); Sun, 24 Nov 2013 05:33:53 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:50106 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185Ab3KXKdB (ORCPT ); Sun, 24 Nov 2013 05:33:01 -0500 From: Frederic Weisbecker To: LKML Cc: Oleg Nesterov , , Frederic Weisbecker Subject: [PATCH 4/4] sh: Fix hw_breakpoint the range check Date: Sun, 24 Nov 2013 11:32:51 +0100 Message-Id: <1385289171-3411-5-git-send-email-fweisbec@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1385289171-3411-1-git-send-email-fweisbec@gmail.com> References: <1385289171-3411-1-git-send-email-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oleg Nesterov arch_check_bp_in_kernelspace() tries to avoid the overflow and does 2 TASK_SIZE checks but it needs OR, not AND. Consider va = TASK_SIZE -1 and len = 2 case. Signed-off-by: Oleg Nesterov Fixes: 09a072947791088b88ae15111cf68fc5aaaf758d Cc: Signed-off-by: Frederic Weisbecker --- arch/sh/kernel/hw_breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c index f917376..9801674 100644 --- a/arch/sh/kernel/hw_breakpoint.c +++ b/arch/sh/kernel/hw_breakpoint.c @@ -132,7 +132,7 @@ int arch_check_bp_in_kernelspace(struct perf_event *bp) va = info->address; len = get_hbp_len(info->len); - return (va >= TASK_SIZE) && ((va + len - 1) >= TASK_SIZE); + return (va >= TASK_SIZE) || ((va + len - 1) >= TASK_SIZE); } int arch_bp_generic_fields(int sh_len, int sh_type, -- 1.8.3.1