From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung.kim@lge.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 09/25] perf script: Move evname print code to process_event()
Date: Mon, 25 Nov 2013 11:17:39 -0300 [thread overview]
Message-ID: <1385389075-7989-10-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1385389075-7989-1-git-send-email-acme@infradead.org>
From: Namhyung Kim <namhyung@kernel.org>
The print_sample_start() will be reused by other printing routine for
internal events like COMM, FORK and EXIT from next patch. And because
they're not tied to a specific event, move the evname print code to its
caller.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1384752894-10974-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-script.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index baf17989a216..b392770766dd 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -288,7 +288,6 @@ static void print_sample_start(struct perf_sample *sample,
struct perf_evsel *evsel)
{
struct perf_event_attr *attr = &evsel->attr;
- const char *evname = NULL;
unsigned long secs;
unsigned long usecs;
unsigned long long nsecs;
@@ -323,11 +322,6 @@ static void print_sample_start(struct perf_sample *sample,
usecs = nsecs / NSECS_PER_USEC;
printf("%5lu.%06lu: ", secs, usecs);
}
-
- if (PRINT_FIELD(EVNAME)) {
- evname = perf_evsel__name(evsel);
- printf("%s: ", evname ? evname : "[unknown]");
- }
}
static bool is_bts_event(struct perf_event_attr *attr)
@@ -434,6 +428,11 @@ static void process_event(union perf_event *event, struct perf_sample *sample,
print_sample_start(sample, thread, evsel);
+ if (PRINT_FIELD(EVNAME)) {
+ const char *evname = perf_evsel__name(evsel);
+ printf("%s: ", evname ? evname : "[unknown]");
+ }
+
if (is_bts_event(attr)) {
print_sample_bts(event, sample, evsel, machine, thread);
return;
--
1.8.1.4
next prev parent reply other threads:[~2013-11-25 14:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 14:17 [GIT PULL 00/25] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 01/25] tools lib traceevent: Use helper trace-seq in print functions like kernel does Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 02/25] perf trace: Remove thread summary coloring Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 03/25] perf top: Make -g refer to callchains Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 04/25] perf completion: Introduce a layer of indirection Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 05/25] perf completion: Factor out compgen stuff Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 06/25] perf completion: Factor out call to __ltrim_colon_completions Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 07/25] perf completion: Introduce zsh support Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 08/25] perf completion: Rename file to reflect " Arnaldo Carvalho de Melo
2013-11-25 14:17 ` Arnaldo Carvalho de Melo [this message]
2013-11-25 14:17 ` [PATCH 10/25] perf record: Make per-cpu mmaps the default Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 11/25] perf tools: Allow '--inherit' as the negation of '--no-inherit' Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 12/25] perf tools: Add option macro OPT_BOOLEAN_SET Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 13/25] perf record: Default -t option to no inheritance Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 14/25] perf timechart: Always try to print at least 15 tasks Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 15/25] perf timechart: Add option to limit number of tasks Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 16/25] perf timechart: Use proc_num to implement --power-only Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 17/25] perf timechart: Add support for displaying only tasks related data Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 18/25] perf timechart: Group figures and add title with details Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 19/25] perf timechart: Add support for -P and -T in timechart recording Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 20/25] perf timechart: Add backtrace support Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain Arnaldo Carvalho de Melo
2013-11-26 10:52 ` Adrian Hunter
2013-11-26 14:20 ` Arnaldo Carvalho de Melo
2013-11-26 14:30 ` David Ahern
2013-11-26 14:33 ` Arnaldo Carvalho de Melo
2013-11-26 16:18 ` Ingo Molnar
2013-11-25 14:17 ` [PATCH 22/25] perf symbols: Move idle syms check from top to generic function Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 23/25] perf thread: Move comm_list check into function Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 24/25] perf tools: Export setup_list Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 25/25] perf script: Print callchains and symbols if they exist Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385389075-7989-10-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®