mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Olof Johansson <olof@lixom.net>
Subject: [PATCH] gpio: pl061: print resource_size_t as %pa
Date: Tue, 26 Nov 2013 10:56:01 -0800	[thread overview]
Message-ID: <1385492161-27624-1-git-send-email-olof@lixom.net> (raw)

commit 73675c8aa07 ('gpio: pl061: proper error messages') added a printout
of a resource_size_t using %x, which produces an error for builds with
64-bit resources:

drivers/gpio/gpio-pl061.c:345:3: warning: format '%x' expects argument of
    type 'unsigned int', but argument 3 has type 'resource_size_t'

Switch to %pa (and pass in a pointer to the resource instead).

Fixes: 73675c8aa07 ('gpio: pl061: proper error messages')
Signed-off-by: Olof Johansson <olof@lixom.net>
---
 drivers/gpio/gpio-pl061.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
index f08e5e2cbe50..4ed16d7bd13d 100644
--- a/drivers/gpio/gpio-pl061.c
+++ b/drivers/gpio/gpio-pl061.c
@@ -341,8 +341,8 @@ static int pl061_probe(struct amba_device *adev, const struct amba_id *id)
 	}
 
 	amba_set_drvdata(adev, chip);
-	dev_err(&adev->dev, "PL061 GPIO chip @%08x registered\n",
-		adev->res.start);
+	dev_err(&adev->dev, "PL061 GPIO chip @%pa registered\n",
+		&adev->res.start);
 
 	return 0;
 }
-- 
1.8.4.1.601.g02b3b1d


             reply	other threads:[~2013-11-26 18:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 18:56 Olof Johansson [this message]
2013-11-26 19:14 ` Joe Perches
2013-11-26 19:17   ` Olof Johansson
2013-11-26 23:49     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385492161-27624-1-git-send-email-olof@lixom.net \
    --to=olof@lixom.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®