From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755917Ab3K0DVZ (ORCPT ); Tue, 26 Nov 2013 22:21:25 -0500 Received: from smtprelay0172.hostedemail.com ([216.40.44.172]:33105 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752784Ab3K0DVU (ORCPT ); Tue, 26 Nov 2013 22:21:20 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3866:3867:3871:3873:4250:4321:5007:7652:10004:10400:10471:10848:11657:11658:11914:12043:12296:12517:12519:12740:13069:13255:13311:13357,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: goose88_45752e2eeea05 X-Filterd-Recvd-Size: 1833 Message-ID: <1385522475.18487.34.camel@joe-AO722> Subject: Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() From: Joe Perches To: Chen Gang Cc: hans.verkuil@cisco.com, m.chehab@samsung.com, rkuo , "linux-kernel@vger.kernel.org" , Greg KH , linux-media@vger.kernel.org, "devel@driverdev.osuosl.org" Date: Tue, 26 Nov 2013 19:21:15 -0800 In-Reply-To: <52956442.50001@gmail.com> References: <528AEFB7.4060301@gmail.com> <20131125011938.GB18921@codeaurora.org> <5292B845.3010404@gmail.com> <5292B8A0.7020409@gmail.com> <5294255E.7040105@gmail.com> <52956442.50001@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: > dev_*() assumes 'go' is already initialized, so need use pr_*() instead > of before 'go' initialized. [] > diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c [] > @@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf, > char *name; > int video_pipe, i, v_urb_len; > > - dev_dbg(go->dev, "probing new GO7007 USB board\n"); > + pr_devel("probing new GO7007 USB board\n"); pr_devel is commonly compiled out completely unless DEBUG is #defined. You probably want to use pr_debug here.