From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: [PATCH 2/5] ASoC: twl6040: Custom caching for sensitive DL1/2 path registers
Date: Fri, 29 Nov 2013 16:03:44 +0200 [thread overview]
Message-ID: <1385733827-19831-3-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1385733827-19831-1-git-send-email-peter.ujfalusi@ti.com>
Introduce a small register cache for registers which needs special caching
to reduce pop noise:
TWL6040_REG_HSLCTL, TWL6040_REG_HSRCTL, TWL6040_REG_EARCTL, TWL6040_REG_HFLCTL
and TWL6040_REG_HFRCTL.
Switch over and use the new small cache for these registers instead of the
main reg_cache.
This is in preparation to remove the local ASoC reg_cache from the driver.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/codecs/twl6040.c | 51 ++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 49 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
index ef13a50..fb8c65b 100644
--- a/sound/soc/codecs/twl6040.c
+++ b/sound/soc/codecs/twl6040.c
@@ -72,6 +72,7 @@ struct twl6040_data {
int hs_power_mode_locked;
bool dl1_unmuted;
bool dl2_unmuted;
+ u8 dl12_cache[TWL6040_REG_HFRCTL - TWL6040_REG_HSLCTL + 1];
unsigned int clk_in;
unsigned int sysclk;
struct twl6040_jack_data hs_jack;
@@ -174,18 +175,62 @@ static struct snd_pcm_hw_constraint_list sysclk_constraints[] = {
{ .count = ARRAY_SIZE(hp_rates), .list = hp_rates, },
};
+static inline int twl6040_read_dl12_cache(struct snd_soc_codec *codec,
+ u8 reg, u8 *value)
+{
+ struct twl6040_data *priv = snd_soc_codec_get_drvdata(codec);
+ int ret = 0;
+
+ switch (reg) {
+ case TWL6040_REG_HSLCTL:
+ case TWL6040_REG_HSRCTL:
+ case TWL6040_REG_EARCTL:
+ case TWL6040_REG_HFLCTL:
+ case TWL6040_REG_HFRCTL:
+ *value = priv->dl12_cache[reg - TWL6040_REG_HSLCTL];
+ break;
+ default:
+ ret = -EINVAL;
+ break;
+ }
+
+ return ret;
+}
+
/*
* read twl6040 register cache
*/
static inline unsigned int twl6040_read_reg_cache(struct snd_soc_codec *codec,
- unsigned int reg)
+ unsigned int reg)
{
u8 *cache = codec->reg_cache;
+ u8 value;
if (reg >= TWL6040_CACHEREGNUM)
return -EIO;
- return cache[reg];
+ if (twl6040_read_dl12_cache(codec, reg, &value))
+ value = cache[reg];
+
+ return value;
+}
+
+static inline void twl6040_update_dl12_cache(struct snd_soc_codec *codec,
+ u8 reg, u8 value)
+{
+ struct twl6040_data *priv = snd_soc_codec_get_drvdata(codec);
+
+ switch (reg) {
+ case TWL6040_REG_HSLCTL:
+ case TWL6040_REG_HSRCTL:
+ case TWL6040_REG_EARCTL:
+ case TWL6040_REG_HFLCTL:
+ case TWL6040_REG_HFRCTL:
+ priv->dl12_cache[reg - TWL6040_REG_HSLCTL] = value;
+ break;
+ default:
+ break;
+ }
}
/*
@@ -199,6 +244,8 @@ static inline void twl6040_write_reg_cache(struct snd_soc_codec *codec,
if (reg >= TWL6040_CACHEREGNUM)
return;
cache[reg] = value;
+
+ twl6040_update_dl12_cache(codec, reg, value);
}
/*
--
1.8.4.2
next prev parent reply other threads:[~2013-11-29 14:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 14:03 [PATCH 0/5] ASoC/MFD: twl6040: Remove codec driver local reg cache Peter Ujfalusi
2013-11-29 14:03 ` [PATCH 1/5] ASoC: twl6040: Rename twl6040_is_path_unmuted -> twl6040_can_write_to_chip Peter Ujfalusi
2013-11-29 14:03 ` Peter Ujfalusi [this message]
2013-11-29 14:03 ` [PATCH 3/5] MFD: twl6040: reg_defaults support for regmap Peter Ujfalusi
2013-11-29 16:00 ` Lee Jones
2013-11-29 16:04 ` Mark Brown
2013-12-18 18:56 ` Mark Brown
2013-12-19 9:06 ` Lee Jones
2013-12-19 10:52 ` Mark Brown
2013-12-19 17:20 ` Lee Jones
2013-12-19 18:31 ` Mark Brown
2013-11-29 14:03 ` [PATCH 4/5] ASoC: twl6040: Remove register restore functionality Peter Ujfalusi
2013-11-29 14:03 ` [PATCH 5/5] ASoC: twl6040: Remove self managed local reg_cache support Peter Ujfalusi
2013-11-29 14:49 ` [PATCH 0/5] ASoC/MFD: twl6040: Remove codec driver local reg cache Mark Brown
2013-12-19 18:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385733827-19831-3-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®