From: "Michael Chan" <mchan@broadcom.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Linux PM list" <linux-pm@vger.kernel.org>,
"Linux PCI" <linux-pci@vger.kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Nithin Nayak Sujir" <nsujir@broadcom.com>,
"David Miller" <davem@davemloft.net>
Subject: Re: [PATCH] PCI / tg3: Give up chip reset and carrier loss handling if PCI device is not present
Date: Sun, 1 Dec 2013 12:39:19 -0800 [thread overview]
Message-ID: <1385930359.6988.7.camel@LTIRV-MCHAN1.corp.ad.broadcom.com> (raw)
In-Reply-To: <7807315.7cU9KldDtM@vostro.rjw.lan>
On Sun, 2013-12-01 at 02:34 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Modify tg3_chip_reset() and tg3_close() to check if the PCI network
> adapter device is accessible at all in order to skip poking it or
> trying to handle a carrier loss in vain when that's not the case.
> Introduce a special PCI helper function pci_device_is_present()
> for this purpose.
>
> Of course, this uncovers the lack of the appropriate RTNL locking
> in tg3_suspend() and tg3_resume(), so add that locking in there
> too.
>
> These changes prevent tg3 from burning a CPU at 100% load level for
> solid several seconds after the Thunderbolt link is disconnected from
> a Matrox DS1 docking station.
I'm not familiar with the DS1. Does the tg3 device get removed through
tg3_remove_one() in this case? What happens when you reconnect the DS1?
next prev parent reply other threads:[~2013-12-01 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 1:34 Rafael J. Wysocki
2013-12-01 20:39 ` Michael Chan [this message]
2013-12-02 1:18 ` Rafael J. Wysocki
2013-12-02 18:48 ` David Miller
2013-12-02 18:54 ` Michael Chan
2013-12-02 21:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385930359.6988.7.camel@LTIRV-MCHAN1.corp.ad.broadcom.com \
--to=mchan@broadcom.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®