Hello. > Le 30/11/2013 06:01, Alexander Shiyan a écrit : > > Locking is performed by regmap API so no additional locking is > > needed. Nevertheless, keep locking in the ADC conversion routine. > > This need for keep proper read ADC sequence when calling from adc & > > touchscreen drivers. > > You can't do that so easily ! > Regmap only protect against concurrent access to the SPI/I2C bus, but do > not protect the driver's internal data. > And it does not protect against a race between concurrent access at a > higher level : ... > It's OK to do this if you are protected by a mutex, but as soon as you > remove it you will have concurrency between two irq_unmask/irq_mask. irq_unmask/irq_mask and some other functions can be converted to use mc13xxx_reg_rmw. So I'll make a patch for this first. Thanks. --- {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I