From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754499Ab3LBXfc (ORCPT ); Mon, 2 Dec 2013 18:35:32 -0500 Received: from [195.81.139.13] ([195.81.139.13]:35262 "EHLO soller.eu.logitech.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752575Ab3LBXf3 (ORCPT ); Mon, 2 Dec 2013 18:35:29 -0500 X-Greylist: delayed 1067 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Dec 2013 18:35:29 EST From: Olivier Gay To: linux-input@vger.kernel.org Cc: Jiri Kosina , linux-kernel@vger.kernel.org, Olivier Gay , Nestor Lopez Casado , Mathieu Meisser Subject: [PATCH] HID: logitech-dj: add HIDRAW dependency in Kconfig Date: Tue, 3 Dec 2013 00:17:24 +0100 Message-Id: <1386026244-21553-1-git-send-email-ogay@logitech.com> X-Mailer: git-send-email 1.8.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hid-logitech-dj.c driver needs hidraw to work correctly. Without hidraw, hid-logitech-dj.c fails during probe() and Logitech Unifying devices HID reports aren't recognized. Signed-off-by: Olivier Gay Signed-off-by: Nestor Lopez Casado Signed-off-by: Mathieu Meisser --- Hi everyone, this adds a HIDRAW dependency in Kconfig for hid-logitech-dj.c driver. The driver uses hidraw and needs it to work correctly. Without hidraw if a Logitech Unifying device is plugged, the driver fails during probe() and Logitech Unifying devices HID reports aren't recognized. This has been the cause of some confusion. Some Linux and Android distributions had HID_LOGITECH_DJ enabled without HIDRAW and the Unifying mice and keyboards would simply not work (no cursor tracking / no keyboard typing). Best regards, Olivier drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 329fbb9..c8a66b9 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -344,6 +344,7 @@ config HID_LOGITECH config HID_LOGITECH_DJ tristate "Logitech Unifying receivers full support" + depends on HIDRAW depends on HID_LOGITECH ---help--- Say Y if you want support for Logitech Unifying receivers and devices. -- 1.8.4