From: Sricharan R <r.sricharan@ti.com>
To: <r.sricharan@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linus.walleij@linaro.org>,
<linux@arm.linux.org.uk>, <tony@atomide.com>, <rnayak@ti.com>,
<marc.zyngier@arm.com>, <grant.likely@linaro.org>,
<mark.rutland@arm.com>, <robherring2@gmail.com>,
<tglx@linutronix.de>, <galak@codeaurora.org>,
<rob.herring@calxeda.com>, <santosh.shilimkar@ti.com>,
<nm@ti.com>, <bcousson@baylibre.com>
Subject: [PATCH V5 3/4] ARM: OMAP4+: Correct Wakeup-gen code to use physical irq number
Date: Tue, 3 Dec 2013 15:57:24 +0530 [thread overview]
Message-ID: <1386066445-28245-4-git-send-email-r.sricharan@ti.com> (raw)
In-Reply-To: <1386066445-28245-1-git-send-email-r.sricharan@ti.com>
The wakeup gen mask/unmask callback uses the irq element of the
irq_data to setup. The irq is the linux virtual irq number and
is same as the hardware irq number only when the parent irqchip
is setup as a legacy domain. When it is used as a linear domain,
the virtual irqs are allocated dynamically and wakeup gen code
cannot rely on these numbers to access the irq registers. Instead
use the hwirq element of the irq_data which represent the physical
irq number.
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c
index 3664562..693fe48 100644
--- a/arch/arm/mach-omap2/omap-wakeupgen.c
+++ b/arch/arm/mach-omap2/omap-wakeupgen.c
@@ -138,7 +138,7 @@ static void wakeupgen_mask(struct irq_data *d)
unsigned long flags;
raw_spin_lock_irqsave(&wakeupgen_lock, flags);
- _wakeupgen_clear(d->irq, irq_target_cpu[d->irq]);
+ _wakeupgen_clear(d->hwirq, irq_target_cpu[d->hwirq]);
raw_spin_unlock_irqrestore(&wakeupgen_lock, flags);
}
@@ -150,7 +150,7 @@ static void wakeupgen_unmask(struct irq_data *d)
unsigned long flags;
raw_spin_lock_irqsave(&wakeupgen_lock, flags);
- _wakeupgen_set(d->irq, irq_target_cpu[d->irq]);
+ _wakeupgen_set(d->hwirq, irq_target_cpu[d->hwirq]);
raw_spin_unlock_irqrestore(&wakeupgen_lock, flags);
}
--
1.7.9.5
next prev parent reply other threads:[~2013-12-03 10:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 10:27 [PATCH V5 0/4] DRIVERS: IRQCHIP: Add support for crossbar IP Sricharan R
2013-12-03 10:27 ` [PATCH V5 1/4] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs Sricharan R
2013-12-03 10:27 ` [PATCH V5 2/4] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP Sricharan R
2013-12-26 20:01 ` Felipe Balbi
2013-12-27 8:37 ` Sricharan R
2014-01-16 10:22 ` Sricharan R
2014-02-03 11:29 ` Sricharan R
2014-02-04 16:14 ` Thomas Gleixner
2014-02-05 13:11 ` Sricharan R
2014-02-05 14:11 ` Sricharan R
2014-02-26 4:56 ` Sricharan R
2014-02-28 21:36 ` Tony Lindgren
2013-12-03 10:27 ` Sricharan R [this message]
2013-12-03 10:27 ` [PATCH V5 4/4] ARM: DRA: Enable Crossbar IP support for DRA7XX Sricharan R
2013-12-18 9:19 ` [PATCH V5 0/4] DRIVERS: IRQCHIP: Add support for crossbar IP Sricharan R
2013-12-26 4:52 ` Sricharan R
2013-12-26 17:44 ` Santosh Shilimkar
2013-12-27 13:49 ` Sricharan R
2013-12-30 6:28 ` Sricharan R
2014-01-07 23:07 ` Tony Lindgren
2014-01-07 23:55 ` Tony Lindgren
2014-01-08 13:18 ` Sricharan R
2014-01-08 19:18 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386066445-28245-4-git-send-email-r.sricharan@ti.com \
--to=r.sricharan@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=santosh.shilimkar@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®