From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755039Ab3LDIQN (ORCPT ); Wed, 4 Dec 2013 03:16:13 -0500 Received: from s3.sipsolutions.net ([144.76.43.152]:46778 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754999Ab3LDIQK (ORCPT ); Wed, 4 Dec 2013 03:16:10 -0500 Message-ID: <1386144962.4284.2.camel@jlt4.sipsolutions.net> Subject: Re: [PATCH] mac80211: rx: Neaten ieee80211_deliver_skb, remove compare_ether_addr From: Johannes Berg To: Joe Perches Cc: "John W. Linville" , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, LKML Date: Wed, 04 Dec 2013 09:16:02 +0100 In-Reply-To: <1386095360.15309.29.camel@joe-AO722> References: <1386095360.15309.29.camel@joe-AO722> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.5-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-12-03 at 10:29 -0800, Joe Perches wrote: > Remove the unnecessary duplicate test of "if (skb) {" > when !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. > > Remove now unnecessary __maybe_unused, neaten comment > Remove unnecessary parenthesis around align cast. > Substitute reference to deprecated compare_ether_addr > with ether_addr_equal. I already had a patch to remove the __maybe_unused, but this looks good, applied. johannes