From: Joe Perches <joe@perches.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Prarit Bhargava <prarit@redhat.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/3] Introduce FW_INFO* functions and messages
Date: Thu, 05 Dec 2013 07:55:03 -0800 [thread overview]
Message-ID: <1386258903.10003.8.camel@joe-AO722> (raw)
In-Reply-To: <20131205113016.GB3823@console-pimps.org>
On Thu, 2013-12-05 at 11:30 +0000, Matt Fleming wrote:
> On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote:
> > The other part I noticed about this particular patchset is that it's
> > not really "firmware" as such, but specifically PC wiht ACPI that
> > gets covered here. So rather than generalizing the code, another
> > option would be to narrow down the scope and make it
> > acpi_{warn,info,dbg} instead.
>
> Making this specific to ACPI runs the risk of people introducing a
> multitude of new logging functions for every subsystem, e.g.
> efi_{warn,info,dbg}.
There are many subsystem specific logging functions:
$ grep -rP --include=*.[ch] -oh "\b[a-z_]+_warn\b\s*\(" *| \
sed -r 's/\s*//g'|sort|uniq -c|sort -rn|head -25
3808 dev_warn(
1964 pr_warn(
468 netdev_warn(
194 xfs_warn(
120 xhci_warn(
102 ipoib_warn(
76 netif_warn(
64 tuner_warn(
53 hid_warn(
51 ata_dev_warn(
46 mthca_warn(
45 nv_warn(
41 ubi_warn(
32 wiphy_warn(
32 osm_warn(
31 rbd_warn(
28 ubifs_warn(
27 psmouse_warn(
27 e_warn(
25 blogic_warn(
23 en_warn(
23 ata_link_warn(
22 jfs_warn(
21 csio_warn(
21 cam_warn(
> FWIW, I'd be interested in using something like this patch series to
> properly log EFI implementation bugs. The logging for EFI is currently
> done fairly haphazardly.
I thought that was the point of embedding the existing
FW_INFO, FW_WARN and FW_BUG #defines in formats.
Using logging message scraping to find faults is not
a great approach as message content is subject to change.
next prev parent reply other threads:[~2013-12-05 15:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 15:19 [PATCH 0/3] Add Firmware Info, Warn, and Bug messages Prarit Bhargava
2013-12-02 15:19 ` [PATCH 1/3] Introduce FW_INFO* functions and messages Prarit Bhargava
2013-12-03 21:21 ` Andrew Morton
2013-12-04 11:51 ` Prarit Bhargava
2013-12-04 17:20 ` Joe Perches
2013-12-04 18:22 ` Arnd Bergmann
2013-12-05 11:30 ` Matt Fleming
2013-12-05 15:55 ` Joe Perches [this message]
2013-12-06 12:30 ` Matt Fleming
2013-12-16 13:01 ` Prarit Bhargava
2013-12-16 16:31 ` Joe Perches
2013-12-02 15:19 ` [PATCH 2/3] Introduce FW_WARN* " Prarit Bhargava
2013-12-02 15:19 ` [PATCH 3/3] Introduce FW_BUG* " Prarit Bhargava
2013-12-02 17:34 ` [PATCH 0/3] Add Firmware Info, Warn, and Bug messages Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386258903.10003.8.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®