From: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>
Cc: <devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <rob.herring@calxeda.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Kumar Gala <galak@kernel.crashing.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mtd@lists.infradead.org>, <grygorii.strashko@ti.com>,
<dwmw2@infradead.org>, Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
Subject: [PATCH v3 3/9] mtd: nand: davinci: check required ti,davinci-chipselect property
Date: Thu, 5 Dec 2013 19:25:51 +0200 [thread overview]
Message-ID: <1386264358-9738-4-git-send-email-ivan.khoronzhuk@ti.com> (raw)
In-Reply-To: <1386264358-9738-1-git-send-email-ivan.khoronzhuk@ti.com>
The property "ti,davinci-chipselect" is required. So we have to check
if it is set.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Taras Kondratiuk <taras@ti.com>
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
---
drivers/mtd/nand/davinci_nand.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index ddcd7c8..9a96ac7 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -545,6 +545,9 @@ static struct davinci_nand_pdata
if (!of_property_read_u32(pdev->dev.of_node,
"ti,davinci-chipselect", &prop))
pdev->id = prop;
+ else
+ return ERR_PTR(-EINVAL);
+
if (!of_property_read_u32(pdev->dev.of_node,
"ti,davinci-mask-ale", &prop))
pdata->mask_ale = prop;
--
1.7.9.5
next prev parent reply other threads:[~2013-12-05 17:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 17:25 [PATCH v3 0/9] Reuse davinci-nand driver for Keystone arch Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 1/9] mtd: nand: davinci: fix driver registration Ivan Khoronzhuk
2013-12-17 9:24 ` Brian Norris
2013-12-17 10:21 ` ivan.khoronzhuk
2013-12-17 10:43 ` Brian Norris
2013-12-05 17:25 ` [PATCH v3 2/9] mtd: nand: davinci: return ENOMEM if memory allocation is failed Ivan Khoronzhuk
2013-12-05 17:25 ` Ivan Khoronzhuk [this message]
2013-12-05 17:25 ` [PATCH v3 4/9] mtd: nand: davinci: simplify error handling Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 5/9] mtd: nand: davinci: move bindings under mtd Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 6/9] mtd: nand: davinci: extend description of bindings Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 7/9] mtd: nand: davinci: adjust DT properties to MTD generic Ivan Khoronzhuk
2013-12-17 8:50 ` Brian Norris
2013-12-17 12:19 ` ivan.khoronzhuk
2013-12-05 17:25 ` [PATCH v3 8/9] mtd: nand: davinci: reuse driver for Keystone arch Ivan Khoronzhuk
2013-12-05 17:25 ` [PATCH v3 9/9] mtd: nand: davinci: don't request AEMIF address range Ivan Khoronzhuk
2013-12-17 8:42 ` Brian Norris
2013-12-17 10:33 ` ivan.khoronzhuk
2013-12-09 16:44 ` [PATCH v3 0/9] Reuse davinci-nand driver for Keystone arch Santosh Shilimkar
2013-12-14 19:18 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386264358-9738-4-git-send-email-ivan.khoronzhuk@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@kernel.crashing.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®