From: Libin <huawei.libin@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <guohanjun@huawei.com>, <wangyijing@huawei.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] workqueue: Remove redundant call for pwq_adjust_max_active
Date: Mon, 9 Dec 2013 11:30:47 +0800 [thread overview]
Message-ID: <1386559847-33012-1-git-send-email-huawei.libin@huawei.com> (raw)
From: Li Bin <huawei.libin@huawei.com>
In __alloc_workqueue_key(), alloc_and_link_pwqs() already called
pwq_adjust_max_active() to update the pwq's max_active, but after
that there is a redundant call for pwq_adjust_max_active. It is
meanless, remove it.
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
kernel/workqueue.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index c66912be..31cbe1d 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4247,11 +4247,6 @@ struct workqueue_struct *__alloc_workqueue_key(const char *fmt,
*/
mutex_lock(&wq_pool_mutex);
- mutex_lock(&wq->mutex);
- for_each_pwq(pwq, wq)
- pwq_adjust_max_active(pwq);
- mutex_unlock(&wq->mutex);
-
list_add(&wq->list, &workqueues);
mutex_unlock(&wq_pool_mutex);
--
1.8.2.2
reply other threads:[~2013-12-09 3:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386559847-33012-1-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®