From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932718Ab3LIJJw (ORCPT ); Mon, 9 Dec 2013 04:09:52 -0500 Received: from lgeamrelo01.lge.com ([156.147.1.125]:49911 "EHLO LGEAMRELO01.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760928Ab3LIJIG (ORCPT ); Mon, 9 Dec 2013 04:08:06 -0500 X-AuditID: 9c93017d-b7b46ae000000e86-bb-52a5886fff27 From: Joonsoo Kim To: Andrew Morton Cc: Mel Gorman , Rik van Riel , Rafael Aquini , Naoya Horiguchi , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei , Joonsoo Kim Subject: [PATCH v2 5/7] mm/compaction: respect ignore_skip_hint in update_pageblock_skip Date: Mon, 9 Dec 2013 18:10:46 +0900 Message-Id: <1386580248-22431-6-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org update_pageblock_skip() only fits to compaction which tries to isolate by pageblock unit. If isolate_migratepages_range() is called by CMA, it try to isolate regardless of pageblock unit and it don't reference get_pageblock_skip() by ignore_skip_hint. We should also respect it on update_pageblock_skip() to prevent from setting the wrong information. Cc: # 3.7+ Acked-by: Vlastimil Babka Reviewed-by: Naoya Horiguchi Signed-off-by: Joonsoo Kim diff --git a/mm/compaction.c b/mm/compaction.c index 805165b..f58bcd0 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -134,6 +134,10 @@ static void update_pageblock_skip(struct compact_control *cc, bool migrate_scanner) { struct zone *zone = cc->zone; + + if (cc->ignore_skip_hint) + return; + if (!page) return; -- 1.7.9.5