From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761358Ab3LITJy (ORCPT ); Mon, 9 Dec 2013 14:09:54 -0500 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:27660 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755966Ab3LITJq (ORCPT ); Mon, 9 Dec 2013 14:09:46 -0500 X-Greylist: delayed 563 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 Dec 2013 14:09:46 EST X-IronPort-AV: E=Sophos;i="4.93,859,1378882800"; d="scan'208";a="1274934" Subject: Re: [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0 From: Michael Chan To: Nat Gurumoorthy CC: , , In-Reply-To: <1386614601-9453-1-git-send-email-natg@google.com> References: <1386614601-9453-1-git-send-email-natg@google.com> Content-Type: text/plain; charset="cp1252" Date: Mon, 9 Dec 2013 11:00:08 -0800 Message-ID: <1386615608.1752.4.camel@LTIRV-MCHAN1.corp.ad.broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2013-12-09 at 10:43 -0800, Nat Gurumoorthy wrote: > The new tg3 driver leaves REG_BASE_ADDR (PCI config offset 120) > uninitialized. From power on reset this register may have garbage in it. The > Register Base Address register defines the device local address of a > register. The data pointed to by this location is read or written using > the Register Data register (PCI config offset 128). When REG_BASE_ADDR has > garbage any read or write of Register Data Register (PCI 128) will cause the > PCI bus to lock up. The TCO watchdog will fire and bring down the system. > > Is this to prevent problem from other software that may be scanning the PCI config space? It won't help if this happens before the tg3 driver is loaded, right? Thanks.