mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Cohen <david.a.cohen@linux.intel.com>
To: balbi@ti.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	mina86@mina86.com, stern@rowland.harvard.edu,
	David Cohen <david.a.cohen@linux.intel.com>
Subject: [PATCH v7 0/5] add gadget quirk to adapt f_fs for DWC3
Date: Mon,  9 Dec 2013 15:55:33 -0800	[thread overview]
Message-ID: <1386633338-10919-1-git-send-email-david.a.cohen@linux.intel.com> (raw)

Hi,

These patches are a proposal to add gadget quirks in an immediate objective to
adapt f_fs when using DWC3 controller. But the quirk solution is generic and
can be used by other controllers to adapt gadget functions to their
non-standard restrictions.

This change is necessary to make Android's adbd service to work on Intel
Merrifield with f_fs instead of out-of-tree android gadget.

This new patch set was tested and validated in my environment:
 - Intel Merrifield was able to use DWC3/f_fs with adbd service (it wasn't
   before).

Changes from v6 to v7:
 - Downgraded patch set version to v5 as per Felipe Balbi request, with some
   changes:
   - usb_ep_align_maxpacketsize() macro was change to usp_ep_align_maybe()
     in order to check gadget->quirk_ep_out_aligned_size internally.
   - updated patch 4/5 to use new macro usp_ep_align_maybe() and to fix
     following compilation warning:
     $ drivers/usb/gadget/f_fs.c: In function 'ffs_epfile_io':
     $ drivers/usb/gadget/f_fs.c:857:124: warning: comparison of distinct pointer types lacks a cast [enabled by default]

---
David Cohen (3):
  usb: gadget: move bitflags to the end of usb_gadget struct
  usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget
  usb: dwc3: set gadget's quirk ep_out_align_size

Michal Nazarewicz (2):
  usb: gadget: f_fs: remove loop from I/O function
  usb: f_fs: check quirk to pad epout buf size when not aligned to
    maxpacketsize

 drivers/usb/dwc3/gadget.c  |   6 +++
 drivers/usb/gadget/f_fs.c  | 115 +++++++++++++++++++++++----------------------
 include/linux/usb/gadget.h |  39 +++++++++++----
 3 files changed, 94 insertions(+), 66 deletions(-)

-- 
1.8.4.2


             reply	other threads:[~2013-12-09 23:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09 23:55 David Cohen [this message]
2013-12-09 23:55 ` [PATCH v7 1/5] usb: gadget: move bitflags to the end of usb_gadget struct David Cohen
2013-12-09 23:55 ` [PATCH v7 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget David Cohen
2013-12-10  2:34   ` Michal Nazarewicz
2013-12-10  3:35     ` David Cohen
2013-12-10  4:41       ` Felipe Balbi
2013-12-10 19:22         ` David Cohen
2013-12-10 15:01       ` Michal Nazarewicz
2013-12-10 19:21         ` David Cohen
2013-12-09 23:55 ` [PATCH v7 3/5] usb: gadget: f_fs: remove loop from I/O function David Cohen
2013-12-09 23:55 ` [PATCH v7 4/5] usb: f_fs: check quirk to pad epout buf size when not aligned to maxpacketsize David Cohen
2013-12-09 23:55 ` [PATCH v7 5/5] usb: dwc3: set gadget's quirk ep_out_align_size David Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386633338-10919-1-git-send-email-david.a.cohen@linux.intel.com \
    --to=david.a.cohen@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mina86@mina86.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome