From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbdEIHYX (ORCPT ); Tue, 9 May 2017 03:24:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59353 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbdEIHYV (ORCPT ); Tue, 9 May 2017 03:24:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 492901555A Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 492901555A Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170508221943.GA46762@gmail.com> References: <20170508221943.GA46762@gmail.com> <20170508214324.GA124468@beast> <10235.1494280856@warthog.procyon.org.uk> To: Eric Biggers Cc: dhowells@redhat.com, Kees Cook , James Morris , "Serge E. Hallyn" , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] key: Convert big_key payload.data to struct MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13866.1494314658.1@warthog.procyon.org.uk> Date: Tue, 09 May 2017 08:24:18 +0100 Message-ID: <13867.1494314658@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 09 May 2017 07:24:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Biggers wrote: > It probably would be easier to kmalloc() this struct and store a pointer to > it in key->payload.data[0] Yeah, but it's a waste of resources if you don't have to do it. David