From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629Ab3LJUiB (ORCPT ); Tue, 10 Dec 2013 15:38:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33807 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750Ab3LJUh7 (ORCPT ); Tue, 10 Dec 2013 15:37:59 -0500 Date: Tue, 10 Dec 2013 15:37:27 -0500 From: Naoya Horiguchi To: Wanpeng Li Cc: Andrew Morton , Ingo Molnar , Rik van Riel , Mel Gorman , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org Message-ID: <1386707847-amnateda-mutt-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1386667175-19952-9-git-send-email-liwanp@linux.vnet.ibm.com> References: <1386667175-19952-1-git-send-email-liwanp@linux.vnet.ibm.com> <1386667175-19952-9-git-send-email-liwanp@linux.vnet.ibm.com> Subject: Re: [PATCH v4 09/12] sched/numa: fix period_slot recalculation Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Mutt-References: <1386667175-19952-9-git-send-email-liwanp@linux.vnet.ibm.com> X-Mutt-Fcc: ~/Maildir/sent/ User-Agent: Mutt 1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 10, 2013 at 05:19:32PM +0800, Wanpeng Li wrote: > Changelog: > v3 -> v4: > * remove period_slot recalculation > > The original code is as intended and was meant to scale the difference > between the NUMA_PERIOD_THRESHOLD and local/remote ratio when adjusting > the scan period. The period_slot recalculation can be dropped. > > Signed-off-by: Wanpeng Li Reviewed-by: Naoya Horiguchi Thanks, Naoya > --- > kernel/sched/fair.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 7073c76..90b9b88 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1356,7 +1356,6 @@ static void update_task_scan_period(struct task_struct *p, > * scanning faster if shared accesses dominate as it may > * simply bounce migrations uselessly > */ > - period_slot = DIV_ROUND_UP(diff, NUMA_PERIOD_SLOTS); > ratio = DIV_ROUND_UP(private * NUMA_PERIOD_SLOTS, (private + shared)); > diff = (diff * ratio) / NUMA_PERIOD_SLOTS; > } > -- > 1.7.7.6 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org >