From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189Ab3LMGvy (ORCPT ); Fri, 13 Dec 2013 01:51:54 -0500 Received: from lgeamrelo02.lge.com ([156.147.1.126]:43203 "EHLO LGEAMRELO02.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461Ab3LMGud (ORCPT ); Fri, 13 Dec 2013 01:50:33 -0500 X-AuditID: 9c93017e-b7c17ae000003961-c7-52aaae36ef0b From: Joonsoo Kim To: Andrew Morton Cc: Mel Gorman , Rik van Riel , Rafael Aquini , Naoya Horiguchi , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei , Wanpeng Li , Joonsoo Kim Subject: [PATCH v3 1/6] mm/migrate: add comment about permanent failure path Date: Fri, 13 Dec 2013 15:53:26 +0900 Message-Id: <1386917611-11319-2-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1386917611-11319-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1386917611-11319-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Naoya Horiguchi Let's add a comment about where the failed page goes to, which makes code more readable. Acked-by: Christoph Lameter Reviewed-by: Wanpeng Li Signed-off-by: Naoya Horiguchi Signed-off-by: Joonsoo Kim diff --git a/mm/migrate.c b/mm/migrate.c index 3747fcd..c6ac87a 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1123,7 +1123,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, nr_succeeded++; break; default: - /* Permanent failure */ + /* + * Permanent failure (-EBUSY, -ENOSYS, etc.): + * unlike -EAGAIN case, the failed page is + * removed from migration page list and not + * retried in the next outer loop. + */ nr_failed++; break; } -- 1.7.9.5