From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754160Ab3LNU4K (ORCPT ); Sat, 14 Dec 2013 15:56:10 -0500 Received: from mail.sigma-star.at ([95.130.255.111]:62408 "EHLO mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753835Ab3LNU4I (ORCPT ); Sat, 14 Dec 2013 15:56:08 -0500 From: Richard Weinberger To: viro@zeniv.linux.org.uk Cc: dchinner@redhat.com, hch@lst.de, eric.dumazet@gmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger Subject: [PATCH] fs/inode: No need to take ->i_lock right after alloc_inode() Date: Sat, 14 Dec 2013 21:54:55 +0100 Message-Id: <1387054495-31498-1-git-send-email-richard@nod.at> X-Mailer: git-send-email 1.8.4.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In all three cases, new_inode_pseudo(), iget_locked() and iget5_locked(), we own the new inode exclusively at this point and therefore taking ->i_lock to protect ->i_state/->i_hash against concurrent access is superfluous. Signed-off-by: Richard Weinberger --- fs/inode.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 4bcdad3..5f2a735 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -869,9 +869,7 @@ struct inode *new_inode_pseudo(struct super_block *sb) struct inode *inode = alloc_inode(sb); if (inode) { - spin_lock(&inode->i_lock); inode->i_state = 0; - spin_unlock(&inode->i_lock); INIT_LIST_HEAD(&inode->i_sb_list); } return inode; @@ -1025,10 +1023,8 @@ struct inode *iget5_locked(struct super_block *sb, unsigned long hashval, if (set(inode, data)) goto set_failed; - spin_lock(&inode->i_lock); inode->i_state = I_NEW; hlist_add_head(&inode->i_hash, head); - spin_unlock(&inode->i_lock); inode_sb_list_add(inode); spin_unlock(&inode_hash_lock); @@ -1092,10 +1088,8 @@ struct inode *iget_locked(struct super_block *sb, unsigned long ino) old = find_inode_fast(sb, head, ino); if (!old) { inode->i_ino = ino; - spin_lock(&inode->i_lock); inode->i_state = I_NEW; hlist_add_head(&inode->i_hash, head); - spin_unlock(&inode->i_lock); inode_sb_list_add(inode); spin_unlock(&inode_hash_lock); -- 1.8.4.2