mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: <wei.liu2@citrix.com>, <xen-devel@lists.xenproject.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<jonathan.davies@citrix.com>
Subject: Re: [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy
Date: Mon, 16 Dec 2013 10:14:27 +0000	[thread overview]
Message-ID: <1387188867.20076.46.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <52AA33CF.6030004@citrix.com>

On Thu, 2013-12-12 at 22:08 +0000, Zoltan Kiss wrote:
> On 28/11/13 17:43, Ian Campbell wrote:
> > On Thu, 2013-11-28 at 17:37 +0000, Zoltan Kiss wrote:
> > Routing/firewalling domUs is as valid as bridging. There is nothing in
> > the slightest bit suboptimal about it.
> >
> > If this use case regresses with this approach then I'm afraid that
> > either needs to be addressed or a different approach considered.
> >
> >> Anyway, I will try this out, and see if it really copies everything, and
> >> get some numbers as well.
> >
> > Thanks.
> 
> Now I managed to try it out. As I expected, Dom0 does copy the mapped 
> page. The peak throuhput I could get was 6.6 Gbps, however it could keep 
> that only for short periods, I guess when the unmapping was ideally 
> batched. The average was 5.53.
> On the same machine the same 10 min iperf session, without my patches 
> made the peak 5.9 while the average was 5.65. Do you think it is an 
> acceptable regression?

Well, it would of course be preferable to avoid it. I'm quite reluctant
to see this scenario become a second class citizen.

> I used 3.12 Dom0 and guest kernel, the guest transmitted though a 10Gb 
> card to a bare metal box.
> I plan to look further if we can avoid somehow this:
> 
> https://lkml.org/lkml/2012/7/20/363
> 
> So then this scenario can benefit from grant mapping.
> 
> Regards,
> 
> Zoli



      reply	other threads:[~2013-12-16 10:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30  0:50 Zoltan Kiss
2013-10-30  0:50 ` [PATCH net-next RFC 1/5] xen-netback: Introduce TX grant map definitions Zoltan Kiss
2013-10-30  9:28   ` [Xen-devel] " Jan Beulich
2013-10-31 19:22     ` Zoltan Kiss
2013-10-31 19:33   ` Zoltan Kiss
2013-10-30  0:50 ` [PATCH net-next RFC 2/5] xen-netback: Change TX path from grant copy to mapping Zoltan Kiss
2013-10-30  9:11   ` [Xen-devel] " Paul Durrant
2013-10-30 21:10     ` Zoltan Kiss
2013-11-01 16:09       ` Zoltan Kiss
2013-10-30  0:50 ` [PATCH net-next RFC 3/5] xen-netback: Remove old TX grant copy definitons Zoltan Kiss
2013-10-30  9:39   ` [Xen-devel] " Jan Beulich
2013-10-31 19:46     ` Zoltan Kiss
2013-10-30 11:13   ` Wei Liu
2013-10-30  0:50 ` [PATCH net-next RFC 4/5] xen-netback: Fix indentations Zoltan Kiss
2013-10-30 11:13   ` Wei Liu
2013-10-31 19:48     ` Zoltan Kiss
2013-10-30  0:50 ` [PATCH net-next RFC 4/5] xen-netback: Change RX path for mapped SKB fragments Zoltan Kiss
2013-10-30 19:16 ` [Xen-devel] [PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy Konrad Rzeszutek Wilk
2013-10-30 19:17   ` Konrad Rzeszutek Wilk
2013-10-30 21:14     ` Zoltan Kiss
2013-11-01 10:50 ` Ian Campbell
2013-11-01 19:00   ` Zoltan Kiss
2013-11-05 17:01     ` Zoltan Kiss
2013-11-07 10:52     ` Ian Campbell
2013-11-28 17:37       ` Zoltan Kiss
2013-11-28 17:43         ` Ian Campbell
2013-12-12 22:08           ` Zoltan Kiss
2013-12-16 10:14             ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387188867.20076.46.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=jonathan.davies@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zoltan.kiss@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®