From: Joe Perches <joe@perches.com>
To: Laszlo Papp <lpapp@kde.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Lindent formatting issues
Date: Tue, 17 Dec 2013 12:05:26 -0800 [thread overview]
Message-ID: <1387310726.8859.5.camel@joe-AO722> (raw)
In-Reply-To: <CAOMwXhPPN2h2boAOn1=BaHuWa+9nYw=oe1u1bYHtHGyad9Kw8A@mail.gmail.com>
On Tue, 2013-12-17 at 15:06 +0000, Laszlo Papp wrote:
> ./scripts/Lindent seems to be working OK, but there are a few minor
> issues like this:
>
> static struct i2c_driver max6651_driver = {
> .driver = {
> - .name = "gpio-max6651",
> - .owner = THIS_MODULE,
> - },
> + .name = "gpio-max6651",
> + .owner = THIS_MODULE,
> + },
>
> Is there an option or something to mkae it work automatically? I am
> referring to the "}," line which should not have changed.
Assuming that was a copy/paste translation of
tabs to spaces, the first form is more common
in kernel sources and Lindent isn't doing the
right thing here.
You could also use scripts/checkpatch.pl with
the --fix option.
./scripts/checkpatch.pl -f --fix <file>
with various --types=<TYPE,...> options.
Maybe use: https://lkml.org/lkml/2013/9/23/504
next prev parent reply other threads:[~2013-12-17 21:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 15:06 Laszlo Papp
2013-12-17 20:05 ` Joe Perches [this message]
2013-12-19 16:17 ` Laszlo Papp
2013-12-19 16:32 ` Joe Perches
2013-12-19 17:30 ` Laszlo Papp
2013-12-19 17:34 ` Joe Perches
2013-12-19 17:38 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387310726.8859.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lpapp@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®