From: Frederic Weisbecker <fweisbec@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
John Stultz <john.stultz@linaro.org>,
Alex Shi <alex.shi@linaro.org>, Kevin Hilman <khilman@linaro.org>
Subject: [PATCH 02/13] time: New helper to check CPU eligibility to handle timekeeping
Date: Tue, 17 Dec 2013 23:51:21 +0100 [thread overview]
Message-ID: <1387320692-28460-3-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1387320692-28460-1-git-send-email-fweisbec@gmail.com>
Traditionally, all online CPUs in the system are allowed to handle
the timekeeping duty.
Now with the full dynticks subsystem, we don't want the busy CPUs
running tickless to be bothered with housekeeping duties that
require periodic interrupts because that would defeat the main purpose
of running tickless in the first place.
As such, the following rules apply to define the timekeeping duty affinity:
* If we run in full dynticks mode, CPU 0 handles the timekeeping on
behalf of all other CPUs in the system. No other CPU is allowed to
take that duty. This behaviour will soon be subject to change though
as we plan to balance this duty over all the CPUs outside the full
dynticks range with CONFIG_NO_HZ_FULL=y in order to improve power
consumption.
* On any other environment (strict periodic or dynticks idle kernel),
the timekeeping duty can be handled by any CPU.
In order to enforce and consolidate this behaviour, provide an API that
core subsystems can use to check if a CPU is allowed to handle the
timekeeping duty.
This is going to be used by the timer subsystem before assigning a
timekeeper and by RCU for the full sysidle detection.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Alex Shi <alex.shi@linaro.org>
Cc: Kevin Hilman <khilman@linaro.org>
---
include/linux/tick.h | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/include/linux/tick.h b/include/linux/tick.h
index b84773c..cf2fd34 100644
--- a/include/linux/tick.h
+++ b/include/linux/tick.h
@@ -179,15 +179,35 @@ static inline bool tick_nohz_full_cpu(int cpu)
return cpumask_test_cpu(cpu, tick_nohz_full_mask);
}
+/**
+ * tick_timeeping_cpu - check if a CPU is elligble to handle timekeeping duty
+ * @cpu: the cpu to check
+ *
+ * @return true if the CPU is elligible to perform timekeeping duty.
+ */
+static inline bool tick_timekeeping_cpu(int cpu)
+{
+ /*
+ * If there are full dynticks CPUs around,
+ * CPU 0 must stay periodic to update timekeeping.
+ */
+ if (tick_nohz_full_enabled())
+ return cpu == 0;
+
+ /* Otherwise any CPU is elligible for timekeeping duty */
+ return true;
+}
+
extern void tick_nohz_init(void);
extern void __tick_nohz_full_check(void);
extern void tick_nohz_full_kick(void);
extern void tick_nohz_full_kick_all(void);
extern void __tick_nohz_task_switch(struct task_struct *tsk);
-#else
+# else
static inline void tick_nohz_init(void) { }
static inline bool tick_nohz_full_enabled(void) { return false; }
static inline bool tick_nohz_full_cpu(int cpu) { return false; }
+static inline bool tick_timekeeping_cpu(int cpu) { return true; }
static inline void __tick_nohz_full_check(void) { }
static inline void tick_nohz_full_kick(void) { }
static inline void tick_nohz_full_kick_all(void) { }
--
1.8.3.1
next prev parent reply other threads:[~2013-12-17 22:55 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 22:51 [RFC PATCH 00/13] nohz: Use sysidle detection to let the timekeeper sleep Frederic Weisbecker
2013-12-17 22:51 ` [PATCH 01/13] tick: Rename tick_check_idle() to tick_irq_enter() Frederic Weisbecker
2014-01-25 14:22 ` [tip:timers/urgent] " tip-bot for Frederic Weisbecker
2013-12-17 22:51 ` Frederic Weisbecker [this message]
2013-12-17 22:51 ` [PATCH 03/13] rcu: Exclude all potential timekeepers from sysidle detection Frederic Weisbecker
2013-12-17 23:27 ` Paul E. McKenney
2013-12-17 23:49 ` Frederic Weisbecker
2013-12-18 11:43 ` Peter Zijlstra
2013-12-18 11:46 ` Peter Zijlstra
2013-12-18 14:15 ` Paul E. McKenney
2013-12-18 16:24 ` Frederic Weisbecker
2013-12-17 22:51 ` [PATCH 04/13] tick: Use timekeeping_cpu() to elect the CPU handling timekeeping duty Frederic Weisbecker
2013-12-17 23:55 ` Paul E. McKenney
2013-12-17 22:51 ` [PATCH 05/13] rcu: Fix unraised IPI to timekeeping CPU Frederic Weisbecker
2013-12-17 23:21 ` Paul E. McKenney
2013-12-18 14:13 ` Frederic Weisbecker
2013-12-18 14:22 ` Paul E. McKenney
2013-12-18 14:56 ` Frederic Weisbecker
2013-12-18 15:11 ` Peter Zijlstra
2013-12-18 15:58 ` Frederic Weisbecker
2013-12-18 12:12 ` Peter Zijlstra
2013-12-18 15:38 ` Frederic Weisbecker
2013-12-18 15:45 ` Christoph Hellwig
2013-12-18 17:10 ` Peter Zijlstra
2013-12-17 22:51 ` [PATCH 06/13] nohz: Introduce full dynticks' default timekeeping target Frederic Weisbecker
2013-12-17 23:54 ` Paul E. McKenney
2013-12-17 22:51 ` [PATCH 07/13] sched: Enable IPI reception on timekeeper under nohz full system Frederic Weisbecker
2013-12-17 23:52 ` Paul E. McKenney
2013-12-18 14:49 ` Frederic Weisbecker
2013-12-18 15:50 ` Paul E. McKenney
2013-12-18 10:06 ` Peter Zijlstra
2013-12-17 22:51 ` [PATCH 08/13] nohz: Get timekeeping max deferment outside jiffies_lock Frederic Weisbecker
2014-01-25 14:22 ` [tip:timers/urgent] " tip-bot for Frederic Weisbecker
2013-12-17 22:51 ` [PATCH 09/13] nohz: Allow timekeeper's tick to stop when all full dynticks CPUs are idle Frederic Weisbecker
2013-12-17 23:51 ` Paul E. McKenney
2013-12-18 14:36 ` Frederic Weisbecker
2013-12-18 15:29 ` Paul E. McKenney
2013-12-17 22:51 ` [PATCH 10/13] nohz: Hand over timekeeping duty on cpu offlining Frederic Weisbecker
2013-12-17 23:40 ` Paul E. McKenney
2013-12-18 14:19 ` Frederic Weisbecker
2013-12-18 12:30 ` Peter Zijlstra
2013-12-18 16:43 ` Frederic Weisbecker
2013-12-17 22:51 ` [PATCH 11/13] nohz: Wake up timekeeper on exit from sysidle state Frederic Weisbecker
2013-12-17 23:34 ` Paul E. McKenney
2013-12-17 23:52 ` Frederic Weisbecker
2013-12-17 22:51 ` [PATCH 12/13] nohz: Allow all CPUs outside nohz_full range to do timekeeping Frederic Weisbecker
2013-12-17 23:32 ` Paul E. McKenney
2013-12-17 22:51 ` [PATCH 13/13] nohz_full: fix code style issue of tick_nohz_full_stop_tick Frederic Weisbecker
2013-12-18 2:04 ` [RFC PATCH 00/13] nohz: Use sysidle detection to let the timekeeper sleep Alex Shi
2013-12-18 10:19 ` Peter Zijlstra
2013-12-18 14:18 ` Paul E. McKenney
2013-12-18 17:43 ` Frederic Weisbecker
2013-12-18 21:29 ` Andy Lutomirski
2013-12-18 21:49 ` Paul E. McKenney
2013-12-18 21:53 ` Andy Lutomirski
2013-12-18 21:57 ` Paul E. McKenney
2013-12-18 22:55 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387320692-28460-3-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=alex.shi@linaro.org \
--cc=john.stultz@linaro.org \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®