mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vaughan Cao <vaughan.cao@oracle.com>
To: tj@kernel.org
Cc: vaughan.cao@oracle.com, linux-kernel@vger.kernel.org
Subject: [PATCH] async: fix insert entry in ascending list
Date: Wed, 18 Dec 2013 11:15:23 +0800	[thread overview]
Message-ID: <1387336523-13756-1-git-send-email-vaughan.cao@oracle.com> (raw)

Hi Tejun,

I suppose there is a fault in the patch of https://lkml.org/lkml/2013/1/16/546.
I know you made a new patch for latest kernel which don't move the entry
between pending and running list that remove the code I mentioned, but our
kernel is based on v3.8.13 that has the code.

In my understanding, both pending and running list are sorted ascendingly by
cookie value. To find the correct postion to insert the entry into running
list, we traverse reversely to the head. When a node with a smaller cookie is
found, we break out and add the new entry after it. But the origin code tries 
to find a larger cookie and insert itself before that node, it won't result in
a sorted list in any direction...

I don't know if my understanding about the async mechanism is right, so here 
to have a check with you. Thanks.

Signed-off-by: Vaughan Cao <vaughan.cao@oracle.com>
---
 kernel/async.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/async.c b/kernel/async.c
index 6f34904..596c5e7 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -135,9 +135,9 @@ static void async_run_entry_fn(struct work_struct *work)
 	/* 1) move self to the running queue, make sure it stays sorted */
 	spin_lock_irqsave(&async_lock, flags);
 	list_for_each_entry_reverse(pos, &running->domain, list)
-		if (entry->cookie < pos->cookie)
+		if (entry->cookie > pos->cookie)
 			break;
-	list_move_tail(&entry->list, &pos->list);
+	list_move(&entry->list, &pos->list);
 	spin_unlock_irqrestore(&async_lock, flags);
 
 	/* 2) run (and print duration) */
-- 
1.8.3.1


             reply	other threads:[~2013-12-18  3:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18  3:15 Vaughan Cao [this message]
2013-12-18 12:25 ` Tejun Heo
2013-12-18 15:34   ` Vaughan Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387336523-13756-1-git-send-email-vaughan.cao@oracle.com \
    --to=vaughan.cao@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®