From: Gerd Hoffmann <kraxel@redhat.com>
To: Dave Airlie <airlied@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/bochs: new driver
Date: Wed, 18 Dec 2013 08:37:06 +0100 [thread overview]
Message-ID: <1387352226.32378.3.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAPM=9twP1PNFq5OPPeXm_-B3LqGhV777icnL=6tBo+C5n4ydwg@mail.gmail.com>
On Mi, 2013-12-18 at 11:52 +1000, Dave Airlie wrote:
> On Wed, Dec 18, 2013 at 3:04 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > DRM driver for (virtual) vga cards using the bochs dispi
> > interface, such as the qemu standard vga (qemu -vga std).
> >
> > Don't bother supporting anything but 32bpp for now, even
> > though the virtual hardware is able to do that.
>
> Hi Gerd,
>
> just took a quick look over this and it seems in pretty good shape,
> the one worry I have is if you've tested with vesafb loaded, since you
> do some pci_request_regions and fail hard, if vesafb has some of the
> resources this can end up failing the driver load for no good reason.
> I haven't verified there is a problem here its just something we've
> had in the past.
Tested, works. bochs_pci_probe handles it before calling
drm_get_pci_dev, simliar to cirrus.
cheers,
Gerd
next prev parent reply other threads:[~2013-12-18 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 17:04 Gerd Hoffmann
2013-12-18 1:52 ` Dave Airlie
2013-12-18 7:37 ` Gerd Hoffmann [this message]
2013-12-18 8:10 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387352226.32378.3.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®