From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752296Ab3LSAKd (ORCPT ); Wed, 18 Dec 2013 19:10:33 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:51829 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037Ab3LSAKb (ORCPT ); Wed, 18 Dec 2013 19:10:31 -0500 Message-ID: <1387411889.5567.8.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 1/4] drivers: target: Move prototype declaration of function to header file target_core_pr.h From: "Nicholas A. Bellinger" To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, josh@joshtriplett.org Date: Wed, 18 Dec 2013 16:11:29 -0800 In-Reply-To: <1a63603bc5ff05147c419a301d59b135cd0c8406.1387390091.git.rashika.kheria@gmail.com> References: <1a63603bc5ff05147c419a301d59b135cd0c8406.1387390091.git.rashika.kheria@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2013-12-18 at 23:54 +0530, Rashika Kheria wrote: > Move prototype declaration of function > spc_parse_naa_6h_vendor_specific() from target_core_xcopy.c to header > file target_core_pr.h because it is used by more than one file. > > This eliminates the following warning in target_core_spc.c: > drivers/target/target_core_spc.c:138:6: warning: no previous prototype for ‘spc_parse_naa_6h_vendor_specific’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > --- > drivers/target/target_core_pr.h | 5 +++++ > drivers/target/target_core_xcopy.c | 4 ---- > 2 files changed, 5 insertions(+), 4 deletions(-) > Applied to target-pending/for-next. --nab > diff --git a/drivers/target/target_core_pr.h b/drivers/target/target_core_pr.h > index ed75cdd..2ee2936 100644 > --- a/drivers/target/target_core_pr.h > +++ b/drivers/target/target_core_pr.h > @@ -43,6 +43,11 @@ > #define PR_APTPL_MAX_IPORT_LEN 256 > #define PR_APTPL_MAX_TPORT_LEN 256 > > +/* > + * Function defined in target_core_spc.c > + */ > +void spc_parse_naa_6h_vendor_specific(struct se_device *, unsigned char *); > + > extern struct kmem_cache *t10_pr_reg_cache; > > extern void core_pr_dump_initiator_port(struct t10_pr_registration *, > diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c > index 6b88a99..669c536 100644 > --- a/drivers/target/target_core_xcopy.c > +++ b/drivers/target/target_core_xcopy.c > @@ -40,10 +40,6 @@ > > static struct workqueue_struct *xcopy_wq = NULL; > /* > - * From target_core_spc.c > - */ > -extern void spc_parse_naa_6h_vendor_specific(struct se_device *, unsigned char *); > -/* > * From target_core_device.c > */ > extern struct mutex g_device_mutex;