mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH 2/4] drivers: target: Mark function as static in target_core_iblock.c
Date: Wed, 18 Dec 2013 16:11:44 -0800	[thread overview]
Message-ID: <1387411904.5567.9.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <bf4be9c01bc63fc3092132de26196a5a0ed8857d.1387390091.git.rashika.kheria@gmail.com>

On Wed, 2013-12-18 at 23:56 +0530, Rashika Kheria wrote:
> Mark function iblock_get_write_cache() as static in target_core_iblock.c
> because it is not used outside this file.
> 
> This eliminates the following warning in target_core_iblock.c:
> drivers/target/target_core_iblock.c:766:6: warning: no previous prototype for ‘iblock_get_write_cache’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> ---
>  drivers/target/target_core_iblock.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to target-pending/for-next.

--nab

> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index c87959f..15d9121 100644
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -763,7 +763,7 @@ iblock_parse_cdb(struct se_cmd *cmd)
>  	return sbc_parse_cdb(cmd, &iblock_sbc_ops);
>  }
>  
> -bool iblock_get_write_cache(struct se_device *dev)
> +static bool iblock_get_write_cache(struct se_device *dev)
>  {
>  	struct iblock_dev *ib_dev = IBLOCK_DEV(dev);
>  	struct block_device *bd = ib_dev->ibd_bd;



  parent reply	other threads:[~2013-12-19  0:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18 18:24 [PATCH 1/4] drivers: target: Move prototype declaration of function to header file target_core_pr.h Rashika Kheria
2013-12-18 18:26 ` [PATCH 2/4] drivers: target: Mark function as static in target_core_iblock.c Rashika Kheria
2013-12-18 18:38   ` josh
2013-12-19  0:11   ` Nicholas A. Bellinger [this message]
2013-12-18 18:32 ` [PATCH 3/4] drivers: target: Mark functions as static in tcm_loop.c Rashika Kheria
2013-12-18 18:39   ` josh
2013-12-19  0:11   ` Nicholas A. Bellinger
2013-12-18 18:35 ` [PATCH 4/4] drivers: target: Mark functions and structures as static in tfc_conf.c Rashika Kheria
2013-12-18 18:40   ` josh
2013-12-19  0:12   ` Nicholas A. Bellinger
2013-12-18 18:37 ` [PATCH 1/4] drivers: target: Move prototype declaration of function to header file target_core_pr.h josh
2013-12-19  0:11 ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387411904.5567.9.camel@haakon3.risingtidesystems.com \
    --to=nab@linux-iscsi.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®