mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@redhat.com>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Steven Rostedt <rostedt@goodmis.org>,
	David Ahern <dsahern@gmail.com>
Subject: [PATCH 6/9] tools lib traceevent: Use global QUIET_LINK build output
Date: Thu, 19 Dec 2013 14:42:04 +0100	[thread overview]
Message-ID: <1387460527-15030-7-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1387460527-15030-1-git-send-email-jolsa@redhat.com>

Using global QUIET_LINK build output variable and getting
rid of local print_static_lib_build, print_plugin_build
and print_shared_lib_compile.

We no longer distinguish between shared and static
library in the build message. It's differenced by
the built file suffix, like:

  $ make
    ...
    LINK     libtraceevent.a
    LINK     libtraceevent.so

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: David Ahern <dsahern@gmail.com>
---
 tools/lib/traceevent/Makefile | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
index 24203cc..51be8ab 100644
--- a/tools/lib/traceevent/Makefile
+++ b/tools/lib/traceevent/Makefile
@@ -152,14 +152,9 @@ override CFLAGS += $(udis86-flags) -D_GNU_SOURCE
 
 ifeq ($(VERBOSE),1)
   Q =
-  print_shared_lib_compile =
-  print_plugin_build =
   print_install =
 else
   Q = @
-  print_shared_lib_compile =	echo '  BUILD    SHARED LIB '$(OBJ);
-  print_plugin_build =		echo '  BUILD    PLUGIN '$(OBJ);
-  print_static_lib_build =	echo '  BUILD    STATIC LIB '$(OBJ);
   print_install =		echo '  INSTALL  '$1;
 endif
 
@@ -216,10 +211,10 @@ all: all_cmd
 all_cmd: $(CMD_TARGETS)
 
 libtraceevent.so: $(PEVENT_LIB_OBJS)
-	$(Q)$(do_compile_shared_library)
+	$(QUIET_LINK)$(CC) --shared $^ -o $@
 
 libtraceevent.a: $(PEVENT_LIB_OBJS)
-	$(Q)$(do_build_static_lib)
+	$(QUIET_LINK)$(RM) $@; $(AR) rcs $@ $^
 
 plugins: $(PLUGINS)
 
@@ -230,7 +225,7 @@ $(PLUGIN_OBJS): %.o : $(src)/%.c
 	$(QUIET_CC_FPIC)$(CC) -c $(CFLAGS) -fPIC -o $@ $<
 
 $(PLUGINS): %.so: %.o
-	$(Q)$(do_plugin_build)
+	$(QUIET_LINK)$(CC) $(CFLAGS) -shared -nostartfiles -o $@ $<
 
 define make_version.h
 	(echo '/* This file is automatically generated. Do not modify. */';		\
-- 
1.8.3.1


  parent reply	other threads:[~2013-12-19 13:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 13:41 [PATCH 0/9] tools: Factor traceevent/perf Makefile Jiri Olsa
2013-12-19 13:41 ` [PATCH 1/9] perf tests: Factor make install tests Jiri Olsa
2014-01-12 18:33   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 2/9] perf tools: Making QUIET_(CLEAN|INSTAL) variables global Jiri Olsa
2014-01-12 18:33   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 3/9] tools lib traceevent: Remove print_app_build variable Jiri Olsa
2014-01-12 18:34   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 4/9] tools lib traceevent: Use global QUIET_CC build output Jiri Olsa
2014-01-12 18:34   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 5/9] tools lib traceevent: Add global QUIET_CC_FPIC " Jiri Olsa
2014-01-12 18:34   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` Jiri Olsa [this message]
2014-01-12 18:34   ` [tip:perf/core] tools lib traceevent: Use global QUIET_LINK " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 7/9] tools lib traceevent: Use global QUIET_INSTALL " Jiri Olsa
2014-01-12 18:34   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 8/9] tools lib traceevent: Use global QUIET_CLEAN " Jiri Olsa
2014-01-12 18:34   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 9/9] tools lib traceevent: Use global 'O' processing code Jiri Olsa
2014-01-12 18:35   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-20 17:33 ` [PATCH 0/9] tools: Factor traceevent/perf Makefile Jiri Olsa
2013-12-26 13:38 ` Arnaldo Carvalho de Melo
2013-12-26 20:10   ` Jiri Olsa
2013-12-26 20:52     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387460527-15030-7-git-send-email-jolsa@redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®