From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: linus.walleij@linaro.org, broonie@kernel.org,
alsa-devel@alsa-project.org, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 08/11] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case
Date: Thu, 19 Dec 2013 15:55:05 +0000 [thread overview]
Message-ID: <1387468508-12286-9-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1387468508-12286-1-git-send-email-lee.jones@linaro.org>
In this patch we do two things. Firstly, instead of open coding the
store of DMA data in to the DAI for later use, we use the API provided.
Secondly we create and store similar DMA data for the DT case, only
this time we use 'struct snd_dmaengine_dai_dma_data' which is provided
by the core for this very reason.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/ux500/ux500_msp_dai.c | 42 +++++++++++++++++++++++++++++++++++++++--
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_dai.c b/sound/soc/ux500/ux500_msp_dai.c
index bc042cc..f4d607a 100644
--- a/sound/soc/ux500/ux500_msp_dai.c
+++ b/sound/soc/ux500/ux500_msp_dai.c
@@ -17,12 +17,14 @@
#include <linux/bitops.h>
#include <linux/platform_device.h>
#include <linux/clk.h>
+#include <linux/of.h>
#include <linux/regulator/consumer.h>
#include <linux/mfd/dbx500-prcmu.h>
#include <linux/platform_data/asoc-ux500-msp.h>
#include <sound/soc.h>
#include <sound/soc-dai.h>
+#include <sound/dmaengine_pcm.h>
#include "ux500_msp_i2s.h"
#include "ux500_msp_dai.h"
@@ -654,16 +656,52 @@ static int ux500_msp_dai_trigger(struct snd_pcm_substream *substream,
return ret;
}
+static int ux500_msp_dai_of_probe(struct snd_soc_dai *dai)
+{
+ struct ux500_msp_i2s_drvdata *drvdata = dev_get_drvdata(dai->dev);
+ struct snd_dmaengine_dai_dma_data *playback_dma_data;
+ struct snd_dmaengine_dai_dma_data *capture_dma_data;
+
+ playback_dma_data = devm_kzalloc(dai->dev,
+ sizeof(*playback_dma_data),
+ GFP_KERNEL);
+ if (!playback_dma_data)
+ return -ENOMEM;
+
+ capture_dma_data = devm_kzalloc(dai->dev,
+ sizeof(*capture_dma_data),
+ GFP_KERNEL);
+ if (!capture_dma_data)
+ return -ENOMEM;
+
+ playback_dma_data->addr = drvdata->msp->playback_dma_data.tx_rx_addr;
+ capture_dma_data->addr = drvdata->msp->capture_dma_data.tx_rx_addr;
+
+ playback_dma_data->maxburst = 4;
+ capture_dma_data->maxburst = 4;
+
+ snd_soc_dai_init_dma_data(dai, playback_dma_data, capture_dma_data);
+
+ return 0;
+}
+
static int ux500_msp_dai_probe(struct snd_soc_dai *dai)
{
struct ux500_msp_i2s_drvdata *drvdata = dev_get_drvdata(dai->dev);
+ struct msp_i2s_platform_data *pdata = dai->dev->platform_data;
+ int ret;
- dai->playback_dma_data = &drvdata->msp->playback_dma_data;
- dai->capture_dma_data = &drvdata->msp->capture_dma_data;
+ if (!pdata) {
+ ret = ux500_msp_dai_of_probe(dai);
+ return ret;
+ }
drvdata->msp->playback_dma_data.data_size = drvdata->slot_width;
drvdata->msp->capture_dma_data.data_size = drvdata->slot_width;
+ snd_soc_dai_init_dma_data(dai,
+ &drvdata->msp->playback_dma_data,
+ &drvdata->msp->capture_dma_data);
return 0;
}
--
1.8.3.2
next prev parent reply other threads:[~2013-12-19 15:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 15:54 [PATCH 00/10] ASoC: ARM: ux500: Better prepare for full Device Tree Lee Jones
2013-12-19 15:54 ` [PATCH 01/11] ARM: ux500: Don't use enums for MSP IDs - for easy DT conversion Lee Jones
2014-01-07 14:03 ` Linus Walleij
2014-01-07 14:11 ` Lee Jones
2014-01-07 14:19 ` Mark Brown
2014-01-07 14:44 ` Lee Jones
2014-01-07 15:36 ` Mark Brown
2013-12-19 15:54 ` [PATCH 02/11] ASoC: ab8500: Revert back to find_next_bit() Lee Jones
2013-12-19 16:06 ` Takashi Iwai
2013-12-19 16:48 ` Lee Jones
2013-12-19 17:29 ` Takashi Iwai
2013-12-20 14:02 ` Lee Jones
2013-12-20 14:23 ` Takashi Iwai
2013-12-23 10:38 ` Takashi Iwai
2013-12-19 15:55 ` [PATCH 03/11] ASoC: ux500: Provide better checking for Device Tree and/or Platform Data Lee Jones
2014-01-07 15:37 ` Mark Brown
2013-12-19 15:55 ` [PATCH 04/11] ASoC: Ux500: Match platform by device node when booting Device Tree Lee Jones
2014-01-07 15:37 ` Mark Brown
2013-12-19 15:55 ` [PATCH 05/11] ASoC: ux500_pcm: Stop pretending that we support varying address widths Lee Jones
2014-01-07 15:38 ` Mark Brown
2013-12-19 15:55 ` [PATCH 06/11] ASoC: ux500_pcm: Expect different saved DMA data when obtaining from DAI store Lee Jones
2014-01-07 15:38 ` Mark Brown
2013-12-19 15:55 ` [PATCH 07/11] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data Lee Jones
2014-01-07 15:38 ` Mark Brown
2013-12-19 15:55 ` Lee Jones [this message]
2014-01-07 15:38 ` [PATCH 08/11] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case Mark Brown
2013-12-19 15:55 ` [PATCH 09/11] ASoC: ux500_pcm: Take out pointless dev_dbg() call Lee Jones
2014-01-07 15:38 ` Mark Brown
2013-12-19 15:55 ` [PATCH 10/11] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Lee Jones
2014-01-07 15:39 ` Mark Brown
2013-12-19 15:55 ` [PATCH 11/11] ASoC: ux500: Dramatically reduce the size of the DAI driver data struct Lee Jones
2014-01-07 15:39 ` Mark Brown
2013-12-21 14:29 ` [PATCH 00/10] ASoC: ARM: ux500: Better prepare for full Device Tree Mark Brown
2013-12-21 17:19 ` Lee Jones
2014-01-07 14:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387468508-12286-9-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®