From: Ben Hutchings <bhutchings@solarflare.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: David Miller <davem@davemloft.net>, <rashika.kheria@gmail.com>,
<linux-kernel@vger.kernel.org>, <dvhart@linux.intel.com>,
<joe@perches.com>, <andriy.shevchenko@linux.intel.com>,
<vfalico@redhat.com>, <netdev@vger.kernel.org>,
<josh@joshtriplett.org>
Subject: Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c
Date: Thu, 19 Dec 2013 19:13:20 +0000 [thread overview]
Message-ID: <1387480400.1876.32.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <20131219072757.GB4281@netboy>
On Thu, 2013-12-19 at 08:27 +0100, Richard Cochran wrote:
> On Wed, Dec 18, 2013 at 05:43:59PM -0500, David Miller wrote:
> >
> > I think this begs an even more fundamental question, why isn't the PTP
> > driver abstraction providing the necessary methods and interfaces so
> > that pch_gbe doesn't have to call into the ptp_pch.c code directly?
>
> Really it is more of a driver issue. For MAC based PTP clocks, they
> are so tightly coupled to the MAC driver that it is better *not* to
> have the PTP functions in a separate module. Instead, if having the
> PTP stuff optional makes sense, then the PTP parts are just a compile
> time option in the MAC driver. This is how the other MAC drivers with
> optional PTP are structured.
[...]
PTP is no longer a compile-time option in most net drivers.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-12-19 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 20:44 Rashika Kheria
2013-12-15 21:01 ` Josh Triplett
2013-12-16 8:58 ` Richard Cochran
2013-12-18 22:43 ` David Miller
2013-12-18 23:40 ` josh
2013-12-19 7:27 ` Richard Cochran
2013-12-19 19:13 ` Ben Hutchings [this message]
2013-12-19 19:23 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387480400.1876.32.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dvhart@linux.intel.com \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=richardcochran@gmail.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®