From: Joe Perches <joe@perches.com>
To: Ravi Patel <rapatel@apm.com>,
Josh Triplett <josh@joshtriplett.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Kumar Sankaran <ksankaran@apm.com>, Loc Ho <lho@apm.com>,
Keyur Chudgar <kchudgar@apm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch.pl error might be false positive
Date: Thu, 19 Dec 2013 14:15:48 -0800 [thread overview]
Message-ID: <1387491348.2353.20.camel@joe-AO722> (raw)
In-Reply-To: <CAN1v_PvS3dH6HVQ90d=3cfsSdMgieyoDNp3VN-vrHv-aqSFEAw@mail.gmail.com>
(resending adding lkml)
(adding Josh Triplett and Jesse Brandeburg)
On Thu, 2013-12-19 at 13:01 -0800, Ravi Patel wrote:
> Hi Andy, Joe
>
> My name is Ravi Patel and I am working for AppliedMicro.
> I am planning to submit APM X-Gene SoC QMTM drivers to open source after
> running checkpatch.pl
> I am seeing following error saying remove FSF address from my patch, which
> I don't have in my source/header files.
>
> ERROR: Do not include the paragraph about writing to the Free Software
> Foundation's mailing address from the sample GPL notice. The FSF has
> changed addresses in the past, and may do so again. Linux already includes
> a copy of the GPL.
> #1580: FILE: include/misc/xgene/xgene_qmtm.h:19:
> + * You should have received a copy of the GNU General Public License$
>
> Here is my License banner in xgene_qmtm.h
> There are no tabs in my banner
>
> /*
> * AppliedMicro X-Gene SOC Queue Manager/Traffic Manager driver
> *
> * Copyright (c) 2013 Applied Micro Circuits Corporation.
> * Author: Ravi Patel <rapatel@apm.com>
> * Keyur Chudgar <kchudgar@apm.com>
> * Fushen Chen <fchen@apm.com>
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
> * Free Software Foundation; either version 2 of the License, or (at your
> * option) any later version.
> *
> * This program is distributed in the hope that it will be useful,
> * but WITHOUT ANY WARRANTY; without even the implied warranty of
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> * GNU General Public License for more details.
> *
> * You should have received a copy of the GNU General Public License
> * along with this program. If not, see <http://www.gnu.org/licenses/>.
> *
> */
>
> Can you please check if the error is false positive.
Josh?
Is the intent that the "copy of the GNU General Public License"
statement should also be removed?
Jesse had a question recently about the appropriateness of the
removal given the license text.
http://www.spinics.net/lists/netdev/msg262152.html
next parent reply other threads:[~2013-12-19 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN1v_PvS3dH6HVQ90d=3cfsSdMgieyoDNp3VN-vrHv-aqSFEAw@mail.gmail.com>
2013-12-19 22:15 ` Joe Perches [this message]
2013-12-20 7:56 ` Josh Triplett
2013-12-20 8:37 ` Joe Perches
2013-12-20 9:16 ` Josh Triplett
2013-12-20 9:23 ` Joe Perches
2013-12-20 17:03 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387491348.2353.20.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=jesse.brandeburg@intel.com \
--cc=josh@joshtriplett.org \
--cc=kchudgar@apm.com \
--cc=ksankaran@apm.com \
--cc=lho@apm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rapatel@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®