From: Frank Haverkamp <haver@linux.vnet.ibm.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: gregkh@linuxfoundation.org, yongjun_wei@trendmicro.com.cn,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] misc: genwqe: remove unused including <linux/version.h>
Date: Sat, 21 Dec 2013 14:57:06 +0100 [thread overview]
Message-ID: <1387634226.7575.3.camel@oc7383187364.ibm.com> (raw)
In-Reply-To: <CAPgLHd-SWJT8hXN0TPO5E-c2pGnJOOfUP-8NEOMAZBC-nJAQKw@mail.gmail.com>
Hello Wei,
Am Samstag, den 21.12.2013, 17:23 +0800 schrieb Wei Yongjun:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/misc/genwqe/card_sysfs.c | 1 -
> drivers/misc/genwqe/card_base.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/misc/genwqe/card_sysfs.c b/drivers/misc/genwqe/card_sysfs.c
> index a72a992..acd97f3 100644
> --- a/drivers/misc/genwqe/card_sysfs.c
> +++ b/drivers/misc/genwqe/card_sysfs.c
> @@ -24,7 +24,6 @@
> * debugging, please also see the debugfs interfaces of this driver.
> */
>
> -#include <linux/version.h>
> #include <linux/kernel.h>
> #include <linux/types.h>
> #include <linux/module.h>
>
> diff --git a/drivers/misc/genwqe/card_base.h b/drivers/misc/genwqe/card_base.h
> index 41953e3..f034bd7 100644
> --- a/drivers/misc/genwqe/card_base.h
> +++ b/drivers/misc/genwqe/card_base.h
> @@ -34,7 +34,6 @@
> #include <linux/semaphore.h>
> #include <linux/uaccess.h>
> #include <linux/io.h>
> -#include <linux/version.h>
> #include <linux/debugfs.h>
>
> #include <linux/genwqe/genwqe_card.h>
>
Thanks for removing the obsolete includes.
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
prev parent reply other threads:[~2013-12-21 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 9:23 Wei Yongjun
2013-12-21 13:57 ` Frank Haverkamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387634226.7575.3.camel@oc7383187364.ibm.com \
--to=haver@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®