mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: joeyli <jlee@suse.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"samer.el-haj-mahmoud@hp.com" <samer.el-haj-mahmoud@hp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"Elliott@hp.com" <Elliott@hp.com>,
	"werner@suse.com" <werner@suse.com>,
	"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"oneukum@suse.de" <oneukum@suse.de>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"trenn@suse.de" <trenn@suse.de>,
	"matt.fleming@intel.com" <matt.fleming@intel.com>,
	"JBeulich@suse.com" <JBeulich@suse.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"matt@console-pimps.org" <matt@console-pimps.org>
Subject: Re: [RFC PATCH 06/14] rtc-efi: register rtc-efi device when EFI enabled
Date: Sat, 21 Dec 2013 23:34:08 +0800	[thread overview]
Message-ID: <1387640048.3539.5760.camel@linux-s257.site> (raw)
In-Reply-To: <52B4F421.2000403@zytor.com>

於 五,2013-12-20 於 17:51 -0800,H. Peter Anvin 提到:
> On 12/20/2013 05:24 PM, joeyli wrote:
> > 於 五,2013-12-20 於 13:04 -0800,H. Peter Anvin 提到:
> >>
> >> Actually, it doesn't have to reprogram the clock ... it just needs to
> >> know if another OS has already done so.  All Linux needs to do is to be
> >> able to derive UTC from whatever the RTC is set to and to be able to
> >> keep it consistent.
> >>
> > 
> > It's dependent on a right boot initial priority of distribution.
> 
> -ENOPARSE
> 
> > Here have a discussion of adjusting system clock by TZ (from ACPI or
> > UEFI):
> > Discussion on BIOS/CMOS/UEFI clock in local time
> > 	http://www.spinics.net/lists/util-linux-ng/msg07639.html
> > 
> > and,
> > from Ted Ts'o in the mail thread
> >      https://lkml.org/lkml/2008/1/8/195
> > 
> > If kernel use the TZ field from ACPI TAD or EFI to adjust system
> > clock when booting, then it can avoid buggy distributions adjust
> > system clock AFTER e2fsck is run.
> > 
> > Using ACPI TAD should after DSDT parsing in subsystem initial stage,
> > so I choice EFI time services before we can move DSDT parser to
> > start_kernel().
> > 
> 
> Yes, of course.  That is irrelevant to needing to reprogram the clock,
> though.
> 
> My argument is very simple: if we have to rely on EFI, we can get the
> offset in the boot stub before ExitBootServices(), and then simply never
> change it.  That way we still pick up if another operating system has
> changed it, and it will still reflect the proper UTC time.
> 
> 	-hpa
> 

OK, I will add this part to next version for the UEFI system doesn't
have ACPI TAD.


Thanks for your suggestion!
Joey Lee


  reply	other threads:[~2013-12-21 15:35 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  7:51 [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME Lee, Chun-Yi
2013-12-19  7:51 ` [PATCH 01/14] rtc-efi: fix decrease day twice when computing year days Lee, Chun-Yi
2013-12-19  7:51 ` [PATCH 03/14] rtc: block registration of rtc-cmos when CMOS RTC Not Present Lee, Chun-Yi
2013-12-19  7:51 ` [RFC PATCH 04/14] ACPI: Add ACPI 5.0 Time and Alarm Device driver Lee, Chun-Yi
2013-12-19 15:22   ` H. Peter Anvin
2013-12-20  5:41     ` joeyli
2014-01-01  0:42       ` H. Peter Anvin
2014-01-06  8:58         ` joeyli
2014-01-07  5:37           ` H. Peter Anvin
2014-01-07 10:40             ` joeyli
2014-01-07 16:35               ` H. Peter Anvin
2014-01-08 14:59                 ` joeyli
2014-01-08 17:56                   ` H. Peter Anvin
2014-01-09  3:47                     ` joeyli
2014-01-09  4:00                       ` H. Peter Anvin
2014-01-09 12:16                       ` Rafael J. Wysocki
2014-01-02  8:09   ` Lan Tianyu
2014-01-06  9:20     ` joeyli
2013-12-19  7:51 ` [RFC PATCH 05/14] rtc: Add RTC driver of ACPI Time and Alarm Device Lee, Chun-Yi
2013-12-19  7:51 ` [RFC PATCH 06/14] rtc-efi: register rtc-efi device when EFI enabled Lee, Chun-Yi
2013-12-19 14:09   ` Matt Fleming
2013-12-20  4:24     ` joeyli
2013-12-20  4:30       ` H. Peter Anvin
2013-12-20 10:37         ` Borislav Petkov
2013-12-20 15:14           ` Matthew Garrett
2013-12-20 21:04             ` H. Peter Anvin
2013-12-21  1:24               ` joeyli
2013-12-21  1:51                 ` H. Peter Anvin
2013-12-21 15:34                   ` joeyli [this message]
2013-12-20 16:48           ` H. Peter Anvin
2013-12-19  7:51 ` [RFC PATCH 07/14] rtc-efi: add GMTOFF support to rtc_efi Lee, Chun-Yi
2013-12-20 15:11   ` Matthew Garrett
2013-12-21  3:56     ` joeyli
2013-12-19  7:51 ` [RFC PATCH 08/14] rtc-efi: set uie_unsupported for indicate rtc-efi doesn't support UIE mode Lee, Chun-Yi
2013-12-19  7:51 ` [RFC PATCH 09/14] efi: move functions of access efi time to header file for sharing Lee, Chun-Yi
2013-12-19  7:51 ` [RFC PATCH 10/14] rtc: improve and move week day computing function to rtc header Lee, Chun-Yi
2013-12-19  7:51 ` [RFC PATCH 11/14] rtc: switch to get/set rtc time to efi functions if CMOS RTC Not Present git set Lee, Chun-Yi
2013-12-19  7:51 ` [RFC PATCH 12/14] efi: adjust system time base on timezone from EFI time services Lee, Chun-Yi
2013-12-19  7:51 ` [RFC PATCH 13/14] Documentation/RTC: add document of ACPI TAD and EFI TIME driver Lee, Chun-Yi
2013-12-19  7:51 ` [TEST PATCH 14/14] acpi: add early parameter to set CMOS RTC Not Present bit for testing Lee, Chun-Yi
     [not found] ` <1387448416-11672-1-git-send-email-jlee@suse.com>
2013-12-19 10:49   ` [PATCH 02/14] x86-64/efi: Use EFI to deal with platform wall clock (again) Matt Fleming
2013-12-19 13:32     ` joeyli
2013-12-20 11:29       ` One Thousand Gnomes
2013-12-23 23:25         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387640048.3539.5760.camel@linux-s257.site \
    --to=jlee@suse.com \
    --cc=Elliott@hp.com \
    --cc=JBeulich@suse.com \
    --cc=a.zummo@towertech.it \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matt@console-pimps.org \
    --cc=matthew.garrett@nebula.com \
    --cc=mingo@redhat.com \
    --cc=oneukum@suse.de \
    --cc=rjw@rjwysocki.net \
    --cc=rtc-linux@googlegroups.com \
    --cc=samer.el-haj-mahmoud@hp.com \
    --cc=tglx@linutronix.de \
    --cc=trenn@suse.de \
    --cc=werner@suse.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®