From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758064Ab3LWQ3p (ORCPT ); Mon, 23 Dec 2013 11:29:45 -0500 Received: from service87.mimecast.com ([91.220.42.44]:39367 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757509Ab3LWQYF (ORCPT ); Mon, 23 Dec 2013 11:24:05 -0500 From: Pawel Moll To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Samuel Ortiz , Arnd Bergmann , Jon Medhurst , arm@kernel.org, Olof Johansson , Pawel Moll , Greg Kroah-Hartman Subject: [RFC 05/18] driver core: Do not WARN when devres list is not empty at probe time Date: Mon, 23 Dec 2013 16:23:37 +0000 Message-Id: <1387815830-8794-6-git-send-email-pawel.moll@arm.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1387815830-8794-1-git-send-email-pawel.moll@arm.com> References: <1387815830-8794-1-git-send-email-pawel.moll@arm.com> X-OriginalArrivalTime: 23 Dec 2013 16:24:02.0650 (UTC) FILETIME=[64646BA0:01CEFFFB] X-MC-Unique: 113122316240310201 Content-Type: text/plain; charset=WINDOWS-1252 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id rBNGUYxd026696 regmap_init() adds the initialised map to the device resources, which can be then obtained in the driver->probe function in a generic way with dev_reg_regmap(), which makes it independent from underlying hardware interface. This is useful when platform_devices are not simply memory mapped but must use custom way of accessing the registers. Unfortunately the device core WARNs in a situation when probed devices has a non-empty resources list. This patch simply removes this check and doesn't seem to have any side effects. Signed-off-by: Pawel Moll Cc: Greg Kroah-Hartman --- drivers/base/dd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 0605176..07b8419 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -269,7 +269,6 @@ static int really_probe(struct device *dev, struct device_driver *drv) atomic_inc(&probe_count); pr_debug("bus: '%s': %s: probing driver %s with device %s\n", drv->bus->name, __func__, drv->name, dev_name(dev)); - WARN_ON(!list_empty(&dev->devres_head)); dev->driver = drv; -- 1.8.3.2