From: Joe Perches <joe@perches.com>
To: Derek Perrin <d.roc16@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: firmware: edd: fixed coding style errors
Date: Mon, 23 Dec 2013 22:43:52 -0800 [thread overview]
Message-ID: <1387867432.2259.2.camel@joe-AO722> (raw)
In-Reply-To: <2057495.KkFWMBqotF@slave1>
On Mon, 2013-12-23 at 18:53 -0600, Derek Perrin wrote:
> On Sunday, December 22, 2013 02:13:39 PM Joe Perches wrote:
> > On Sun, 2013-12-22 at 15:17 -0600, Derek Perrin wrote:
[]
> > One trivial bit too,
> > > diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
[]
> > > - ssize_t(*show) (struct edd_device * edev, char *buf);
> > > - int (*test) (struct edd_device * edev);
> > > + ssize_t(*show) (struct edd_device *edev, char *buf);
> > > + int (*test) (struct edd_device *edev);
> >
> > I think most prefer function pointer prototypes like:
> >
> > size_t (*show)(struct edd_device *edev, char *buf);
> > int (*test)(struct edd_device *edev);
> I'm not seeing any
> difference between what I did and what you said about the function pointer
> prototypes.
type (*funcptr) (args...)
vs
type (*funcptr)(args...)
2nd is preferred
next prev parent reply other threads:[~2013-12-24 6:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 21:17 Derek Perrin
2013-12-22 22:13 ` Joe Perches
2013-12-24 0:53 ` Derek Perrin
2013-12-24 6:43 ` Joe Perches [this message]
2013-12-25 10:19 ` [PATCH v2] " Derek Perrin
2013-12-25 5:21 ` [PATCH] checkpatch: Add tests for function pointer style misuses Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387867432.2259.2.camel@joe-AO722 \
--to=joe@perches.com \
--cc=d.roc16@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®