Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

[Joe Perches <joe@perches.com>]

On Tue, 2013-12-24 at 20:24 +0400, Sergei Shtylyov wrote:
> On 24-12-2013 15:28, Ding Tianhong wrote:
[]
> > diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
[]
> > @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
> >
> >   static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
> >   {
> > -	return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
> > +	return a->sid == b->sid && ether_addr_equal(a->remote,
> > +							      b->remote);
> 
>     If it really doesn't fit insto single line, the continuation line should 
> start right under 'a->remote'.

Better still might be

	return a->sid == b->sid &&
	       ether_addr_equal(a->remote, b->remote);