mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] low discontig highmem_start_page
Date: Mon, 15 Nov 2004 12:45:50 -0800	[thread overview]
Message-ID: <13880000.1100551550@flay> (raw)
In-Reply-To: <Pine.LNX.4.44.0411152035020.4131-100000@localhost.localdomain>

--On Monday, November 15, 2004 20:37:28 +0000 Hugh Dickins <hugh@veritas.com> wrote:

> In the case of i386 CONFIG_DISCONTIGMEM CONFIG_HIGHMEM without highmem,
> highmem_start_page was wrongly initialized (from a NULL zone_mem_map),
> causing __change_page_attr to BUG on boot.

Thanks, I'm not suprised that was broken - I never test without highmem ;-)

M.
 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> 
> --- 2.6.10-rc2/arch/i386/mm/discontig.c	2004-11-15 16:20:26.000000000 +0000
> +++ linux/arch/i386/mm/discontig.c	2004-11-15 17:01:26.000000000 +0000
> @@ -468,7 +468,7 @@ void __init set_max_mapnr_init(void)
>  	if (high0->spanned_pages > 0)
>  	      	highmem_start_page = high0->zone_mem_map;
>  	else
> -		highmem_start_page = pfn_to_page(max_low_pfn+1); 
> +		highmem_start_page = pfn_to_page(max_low_pfn - 1) + 1; 
>  	num_physpages = highend_pfn;
>  #else
>  	num_physpages = max_low_pfn;
> 
> 



  reply	other threads:[~2004-11-15 20:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-15 20:37 Hugh Dickins
2004-11-15 20:45 ` Martin J. Bligh [this message]
2004-11-15 21:04   ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13880000.1100551550@flay \
    --to=mbligh@aracnet.com \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®