From: Joe Perches <joe@perches.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: akpm@linux-foundation.org,
Manfred Spraul <manfred@colorfullife.com>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] checkpatch: Add tests for function pointer style misuses
Date: Thu, 26 Dec 2013 17:25:38 -0800 [thread overview]
Message-ID: <1388107538.30298.0.camel@joe-AO722> (raw)
In-Reply-To: <20131227005835.GA10986@leaf>
On Thu, 2013-12-26 at 16:58 -0800, Josh Triplett wrote:
> On Thu, Dec 26, 2013 at 12:07:23PM -0800, Josh Triplett wrote:
> > On Thu, Dec 26, 2013 at 11:20:28AM -0800, Joe Perches wrote:
> > > Kernel style uses function pointers in this form:
> > > "type (*funcptr)(args...)"
> > >
> > > Emit warnings when this function pointer form isn't used.
[]
> Here's a patch that fixes the two messages I commented about, which
> applies on top of the version of the patch that went into -mm.
Acked-by: Joe Perches <joe@perches.com>
thanks Josh, Joe
next prev parent reply other threads:[~2013-12-27 1:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 19:20 [PATCH 0/5] checkpatch: A few corrections and updates Joe Perches
2013-12-26 19:20 ` [PATCH 1/5] checkpatch: Add tests for function pointer style misuses Joe Perches
2013-12-26 20:07 ` Josh Triplett
2013-12-27 0:58 ` Josh Triplett
2013-12-27 1:25 ` Joe Perches [this message]
2013-12-26 19:20 ` [PATCH 2/5] checkpatch: Add a --fix-inplace option Joe Perches
2013-12-26 20:08 ` Josh Triplett
2013-12-26 19:20 ` [PATCH 3/5] checkpatch: Improve space before tab --fix option Joe Perches
2013-12-26 19:20 ` [PATCH 4/5] checkpatch: check for if's with unnecessary parentheses Joe Perches
2013-12-26 20:09 ` Josh Triplett
2013-12-26 19:20 ` [PATCH 5/5] checkpatch: Update the FSF/GPL address check Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388107538.30298.0.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®