mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Joe Perches <joe@perches.com>, Kay Sievers <kay@vrfy.org>
Subject: Re: [PATCH] drivers/base: Fix length checks in create_syslog_header()/dev_vprintk_emit()
Date: Fri, 27 Dec 2013 20:10:27 +0100	[thread overview]
Message-ID: <1388171427.26981.77.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20131227184740.GA5180@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]

On Fri, 2013-12-27 at 10:47 -0800, Greg Kroah-Hartman wrote:
> On Fri, Dec 27, 2013 at 06:18:18PM +0100, Ben Hutchings wrote:
> > snprintf() returns the number of bytes that could have been written
> > (excluding the null), not the actual number of bytes written.  Given a
> > long enough subsystem or device name, these functions will advance
> > beyond the end of the on-stack buffer in dev_vprintk_exit(), resulting
> > in an information leak or stack corruption.  I don't know whether such
> > a long name is currently possible.
> > 
> > In case snprintf() returns a value >= the buffer size, do not add
> > structured logging information.  Also WARN the first time this
> > happens, so we can fix the driver or increase the buffer size.
> > 
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> >  drivers/base/core.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index 67b180d..989a93c 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -2022,6 +2022,8 @@ create_syslog_header(const struct device *dev, char *hdr, size_t hdrlen)
> >  		return 0;
> >  
> >  	pos += snprintf(hdr + pos, hdrlen - pos, "SUBSYSTEM=%s", subsys);
> > +	if (pos >= hdrlen)
> > +		goto overflow;
> >  
> >  	/*
> >  	 * Add device identifier DEVICE=:
> > @@ -2053,7 +2055,14 @@ create_syslog_header(const struct device *dev, char *hdr, size_t hdrlen)
> >  				"DEVICE=+%s:%s", subsys, dev_name(dev));
> >  	}
> >  
> > +	if (pos >= hdrlen)
> > +		goto overflow;
> > +
> >  	return pos;
> > +
> > +overflow:
> > +	dev_WARN_ONCE(dev, 1, "device/subsystem name too long");
> 
> Why only warn once?  Any device/subsystem mix should be complained
> about, if for only that we should be really annoying about it to get it
> resolved.

This would expand the volume of logging for the problem device by a
factor of ~50 so it doesn't seem like a good failure mode.

Ben.

-- 
Ben Hutchings
Computers are not intelligent.	They only think they are.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2013-12-27 19:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-27 17:18 Ben Hutchings
2013-12-27 18:47 ` Greg Kroah-Hartman
2013-12-27 19:10   ` Ben Hutchings [this message]
2013-12-27 19:17     ` Joe Perches
2014-01-13 18:52     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388171427.26981.77.camel@deadeye.wl.decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®