mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Galbraith <bitbucket@online.de>
To: Lei Wen <adrian.wenl@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	leiwen@marvell.com
Subject: Re: [RFC] sched: update rq clock when only get preempt
Date: Mon, 30 Dec 2013 05:08:28 +0100	[thread overview]
Message-ID: <1388376508.5345.23.camel@marge.simpson.net> (raw)
In-Reply-To: <CALZhoST3oQnSOv0ZQ6CiHDgTC4D+t=Kd4Gp4oPqrnH__qMZ7Hw@mail.gmail.com>

On Mon, 2013-12-30 at 11:14 +0800, Lei Wen wrote: 
> Since we would update rq clock at task enqueue/dequeue, or schedule
> tick. If we don't update the rq clock when our previous task get
> preempted, our new started task would get a relative stale rq clock
> which is updated during the previous task enqueue, or the last schedule
> clock update.

> @@ -2555,6 +2556,8 @@ need_resched:
>                 idle_balance(cpu, rq);
> 
>         put_prev_task(rq, prev);
> +       if (update)
> +               update_rq_clock(rq);

If prev remained enqueued, the clock was updated by put_prev_task().

-Mike


  reply	other threads:[~2013-12-30  4:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30  3:14 Lei Wen
2013-12-30  4:08 ` Mike Galbraith [this message]
2013-12-30  4:56   ` Lei Wen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388376508.5345.23.camel@marge.simpson.net \
    --to=bitbucket@online.de \
    --cc=adrian.wenl@gmail.com \
    --cc=leiwen@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®