From: Joe Perches <joe@perches.com>
To: Ding Tianhong <dingtianhong@huawei.com>
Cc: Ding Tianhong <dthxman@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr
Date: Sun, 29 Dec 2013 22:05:26 -0800 [thread overview]
Message-ID: <1388383526.26796.21.camel@joe-AO722> (raw)
In-Reply-To: <52C0DCF7.6040402@huawei.com>
On Mon, 2013-12-30 at 10:39 +0800, Ding Tianhong wrote:
> I don't understand packetengine NIC anymore, But I think the change is clearly,
> as your said, the broadcast check is enough here, did you mean that?
>
> !is_broadcast_ether_addr((u8 *)(le32_to_cpu(yp->rx_ring_dma) +
> entry * sizeof(struct yellowfin_desc)))
Not quite. I meant this could be:
u8 *addr = (u8 *)(unsigned long)le32_to_cpu(yp->rx_ring_dma) +
entry * sizeof(struct yellowfin_desc);
if (!ether_addr_equal(addr, dev->dev_addr) &&
!is_broadcast_ether_addr(addr)) {
etc...
but again, I think thus hardly matters and could just as well
be left alone.
next prev parent reply other threads:[~2013-12-30 6:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 6:17 Ding Tianhong
2013-12-28 13:58 ` Sergei Shtylyov
2013-12-28 15:18 ` Ding Tianhong
2013-12-28 17:23 ` Joe Perches
2013-12-30 2:39 ` Ding Tianhong
2013-12-30 6:05 ` Joe Perches [this message]
2013-12-30 6:19 ` Ding Tianhong
2013-12-28 23:25 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388383526.26796.21.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=dthxman@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®