From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E2F9ECAAD5 for ; Mon, 5 Sep 2022 14:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238067AbiIEOMu convert rfc822-to-8bit (ORCPT ); Mon, 5 Sep 2022 10:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237528AbiIEOMp (ORCPT ); Mon, 5 Sep 2022 10:12:45 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75CDF3D5B4 for ; Mon, 5 Sep 2022 07:12:43 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oVCpw-0006go-Bt; Mon, 05 Sep 2022 16:12:28 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, Conor.Dooley@microchip.com Cc: guoren@kernel.org, apatel@ventanamicro.com, atishp@rivosinc.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] riscv: use BIT() marco for cpufeature probing Date: Mon, 05 Sep 2022 16:12:26 +0200 Message-ID: <13885578.y0N7aAr316@diego> In-Reply-To: <7693745.aoefvbuG5b@diego> References: <20220905111027.2463297-1-heiko@sntech.de> <1e61d31a-9bf5-af79-dbc4-87d63d24b497@microchip.com> <7693745.aoefvbuG5b@diego> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 5. September 2022, 13:23:01 CEST schrieb Heiko Stübner: > Am Montag, 5. September 2022, 13:19:41 CEST schrieb Conor.Dooley@microchip.com: > > On 05/09/2022 12:10, Heiko Stuebner wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > > > Using the appropriate BIT macro makes the code better readable. > > > > > > Suggested-by: Conor Dooley > > > Signed-off-by: Heiko Stuebner > > > > Missing the cover-letter with the changelog? > > At least, I didn't get it in my inbox. > > darn git send-email and its automatic selection ;-) > > I.e. I _should_ have added you to the hard recipient list for my series > in the first place, but instead git send-email selected you based on > the Suggested-by ... but it looks like these selectoions don't get > applied to the cover-letter ... sorry about that For the record, the series is here: https://lore.kernel.org/all/20220905111027.2463297-1-heiko@sntech.de/ Though right now, I don't see it in the linux-riscv list-archive or my own inbox of that list. Maybe infradead has some issue today. > > > Heiko > > > > Either way, > > > > Reviewed-by: Conor Dooley > > > > > --- > > > arch/riscv/kernel/cpufeature.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > > index 729f7a218093..08f7445985dc 100644 > > > --- a/arch/riscv/kernel/cpufeature.c > > > +++ b/arch/riscv/kernel/cpufeature.c > > > @@ -289,10 +289,10 @@ static u32 __init_or_module cpufeature_probe(unsigned int stage) > > > u32 cpu_req_feature = 0; > > > > > > if (cpufeature_probe_svpbmt(stage)) > > > - cpu_req_feature |= (1U << CPUFEATURE_SVPBMT); > > > + cpu_req_feature |= BIT(CPUFEATURE_SVPBMT); > > > > > > if (cpufeature_probe_zicbom(stage)) > > > - cpu_req_feature |= (1U << CPUFEATURE_ZICBOM); > > > + cpu_req_feature |= BIT(CPUFEATURE_ZICBOM); > > > > > > return cpu_req_feature; > > > } > > > -- > > > 2.35.1 > > > > > > > > >