From: Christian Eggers <ceggers@gmx.de>
To: spi-devel-general@lists.sourceforge.net, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: [resubmit2] [PATCH] spi: spi-davinci: Fix direction in dma_map_single()
Date: Mon, 29 Jul 2013 20:54:09 +0200 [thread overview]
Message-ID: <1388690.s58sU4PUYE@p2400> (raw)
The following patch I already sent on 2013-04-18 and 2013-06-06.
Unfortunately it hasn't been committed yet.
Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci:
convert to DMA engine API) introduced a regression: dma_map_single()
is called with direction DMA_FROM_DEVICE for rx and for tx.
Signed-off-by: Christian Eggers <ceggers@gmx.de>
Cc: stable@vger.kernel.org # v3.7.x+
Acked-by: Matt Porter <mporter@ti.com>
---
--- drivers/spi/spi-davinci.c.orig 2013-04-18 20:54:02.728719412 +0200
+++ drivers/spi/spi-davinci.c 2013-04-18 20:54:51.900623956 +0200
@@ -608,7 +608,7 @@ static int davinci_spi_bufs(struct spi_d
else
buf = (void *)t->tx_buf;
t->tx_dma = dma_map_single(&spi->dev, buf,
- t->len, DMA_FROM_DEVICE);
+ t->len, DMA_TO_DEVICE);
if (!t->tx_dma) {
ret = -EFAULT;
goto err_tx_map;
next reply other threads:[~2013-07-29 18:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 18:54 Christian Eggers [this message]
2013-07-29 19:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388690.s58sU4PUYE@p2400 \
--to=ceggers@gmx.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®